Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEXT_RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ The release notes should contain at least the following sections:
* [terraform] New variable `schema_manager_enabled` (default `true`), passed to Helm and Tanka.
* [helm] The service name of the Go profiler can now be set with `dss.conf.gcpProfServiceName`.
* [terraform] New variable `gcp_prof_service_name` (default empty), passed to Helm and Tanka.
* [helm] The image of the schema manager and evict jobs can now be set with `dss.schemaManager.image` (defaults to `dss.image`).
* [terraform] New variable `schema_manager_image` (defaults to `image`), passed to Helm and Tanka.

## Minimal database schema version

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ resource "local_file" "helm_chart_values" {

schemaManager = {
enabled = var.schema_manager_enabled
image = var.schema_manager_image
desiredRidDbVersion = local.rid_db_schema
desiredScdDbVersion = local.scd_db_schema
desiredAuxDbVersion = local.aux_db_schema
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ resource "local_file" "tanka_config_main" {
VAR_DESIRED_SCD_DB_VERSION = local.scd_db_schema
VAR_DESIRED_AUX_DB_VERSION = local.aux_db_schema
VAR_SCHEMA_MANAGER_ENABLED = var.schema_manager_enabled
VAR_SCHEMA_MANAGER_IMAGE = var.schema_manager_image != "" ? var.schema_manager_image : var.image
VAR_SHOULD_INIT = var.should_init
VAR_DOCKER_IMAGE_PULL_SECRET = var.image_pull_secret != null ? var.image_pull_secret : ""
VAR_CLOUD_PROVIDER = var.kubernetes_cloud_provider_name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ local metadata = metadataBase {
},
schema_manager+: {
enable: ${VAR_SCHEMA_MANAGER_ENABLED},
image: '${VAR_DOCKER_IMAGE_NAME}',
image: '${VAR_SCHEMA_MANAGER_IMAGE}',
desired_rid_db_version: '${VAR_DESIRED_RID_DB_VERSION}',
desired_scd_db_version: '${VAR_DESIRED_SCD_DB_VERSION}',
desired_aux_db_version: '${VAR_DESIRED_AUX_DB_VERSION}',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,17 @@ variable "schema_manager_enabled" {
}


variable "schema_manager_image" {
type = string
default = ""
description = <<-EOT
Image used by the schema manager and evict jobs. When empty, `image` is used.

Example: `docker.io/interuss/dss:v0.15.0`
EOT
}


variable "crdb_image_tag" {
type = string
description = <<-EOT
Expand Down
5 changes: 5 additions & 0 deletions deploy/infrastructure/modules/terraform-aws-dss/TFVARS.gen.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,11 @@ Currently, only single node or three nodes deployments are supported.</p>
With Tanka, the schema manager jobs are always deployed when <code>should_init</code> is true.</p>
<p>Example: <code>true</code></p>
<br/>Default value: <code>true</code></td>
</tr><tr>
<td>schema_manager_image (<code>string</code>)</td>
<td><p>Image used by the schema manager and evict jobs. When empty, <code>image</code> is used.</p>
<p>Example: <code>docker.io/interuss/dss:v0.15.0</code></p>
<br/>Default value: <code>""</code></td>
</tr><tr>
<td>should_init (<code>bool</code>)</td>
<td><p>Set to false if joining an existing pool, true if creating the first DSS instance
Expand Down
1 change: 1 addition & 0 deletions deploy/infrastructure/modules/terraform-aws-dss/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ module "terraform-commons-dss" {
desired_scd_db_version = var.desired_scd_db_version
desired_aux_db_version = var.desired_aux_db_version
schema_manager_enabled = var.schema_manager_enabled
schema_manager_image = var.schema_manager_image
authorization = var.authorization
locality = var.locality
crdb_external_nodes = var.crdb_external_nodes
Expand Down
11 changes: 11 additions & 0 deletions deploy/infrastructure/modules/terraform-aws-dss/variables.gen.tf
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,17 @@ variable "schema_manager_enabled" {
}


variable "schema_manager_image" {
type = string
default = ""
description = <<-EOT
Image used by the schema manager and evict jobs. When empty, `image` is used.

Example: `docker.io/interuss/dss:v0.15.0`
EOT
}


variable "crdb_image_tag" {
type = string
description = <<-EOT
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,11 @@ Currently, only single node or three nodes deployments are supported.</p>
With Tanka, the schema manager jobs are always deployed when <code>should_init</code> is true.</p>
<p>Example: <code>true</code></p>
<br/>Default value: <code>true</code></td>
</tr><tr>
<td>schema_manager_image (<code>string</code>)</td>
<td><p>Image used by the schema manager and evict jobs. When empty, <code>image</code> is used.</p>
<p>Example: <code>docker.io/interuss/dss:v0.15.0</code></p>
<br/>Default value: <code>""</code></td>
</tr><tr>
<td>should_init (<code>bool</code>)</td>
<td><p>Set to false if joining an existing pool, true if creating the first DSS instance
Expand Down
1 change: 1 addition & 0 deletions deploy/infrastructure/modules/terraform-google-dss/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ module "terraform-commons-dss" {
desired_scd_db_version = var.desired_scd_db_version
desired_aux_db_version = var.desired_aux_db_version
schema_manager_enabled = var.schema_manager_enabled
schema_manager_image = var.schema_manager_image
authorization = var.authorization
locality = var.locality
image_pull_secret = var.image_pull_secret
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,17 @@ variable "schema_manager_enabled" {
}


variable "schema_manager_image" {
type = string
default = ""
description = <<-EOT
Image used by the schema manager and evict jobs. When empty, `image` is used.

Example: `docker.io/interuss/dss:v0.15.0`
EOT
}


variable "crdb_image_tag" {
type = string
description = <<-EOT
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
variable "schema_manager_image" {
type = string
default = ""
description = <<-EOT
Image used by the schema manager and evict jobs. When empty, `image` is used.

Example: `docker.io/interuss/dss:v0.15.0`
EOT
}
1 change: 1 addition & 0 deletions deploy/infrastructure/utils/variables.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"desired_scd_db_version",
"desired_aux_db_version",
"schema_manager_enabled",
"schema_manager_image",
"crdb_image_tag",
"crdb_cluster_name",
"crdb_cache",
Expand Down
11 changes: 11 additions & 0 deletions deploy/operations/ci/aws-1/variables.gen.tf
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,17 @@ variable "schema_manager_enabled" {
}


variable "schema_manager_image" {
type = string
default = ""
description = <<-EOT
Image used by the schema manager and evict jobs. When empty, `image` is used.

Example: `docker.io/interuss/dss:v0.15.0`
EOT
}


variable "crdb_image_tag" {
type = string
description = <<-EOT
Expand Down
2 changes: 1 addition & 1 deletion deploy/services/helm-charts/dss/templates/dss-evict.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- $image := .Values.dss.image }}
{{- $image := .Values.dss.schemaManager.image | default .Values.dss.image }}

{{- $datastoreImage := (include "datastoreImage" .) -}}
{{- $datastoreHost := (include "datastoreHost" .) -}}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- $image := .Values.dss.image }}
{{- $image := .Values.dss.schemaManager.image | default .Values.dss.image }}
{{- $datastoreHost := (include "datastoreHost" .) -}}
{{- $datastorePort := (include "datastorePort" .) -}}
{{- $datastoreUser := (include "datastoreUser" .) -}}
Expand Down
4 changes: 4 additions & 0 deletions deploy/services/helm-charts/dss/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,10 @@
"type": "boolean",
"description": "Deploy the schema manager jobs."
},
"image": {
"type": "string",
"description": "Optional: Image used by the schema manager and evict jobs. Defaults to `dss.image`."
},
"desiredRidDbVersion": {
"type": "string",
"description": "Desired RID DB schema version. When empty, the latest version for the datastore is used. Example: `4.1.0`"
Expand Down
Loading