Conversation
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
anko-intel
requested changes
Sep 16, 2026
anko-intel
left a comment
anko-intel
left a comment
Contributor
There was a problem hiding this comment.
see also:
max_val = jnp.max(jnp.abs(orig_weight), axis=axis, keepdims=True)
in neural_compressor/jax/utils/utility.py
Maybe we can remove max(abs( there?
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
Contributor
Author
get_scale() is used both for activations and kernel. While for activations it's redundant due to AbsMaxObserver, it is still necessary for kernel scale |
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
feature
Description
Implements new AbsMaxObserver for the JAX static quantization calibration path and wires it into eligible layers.
Expected Behavior & Potential Risk
How has this PR been tested?
Dependency Change?
None