Skip to content

servershell: support multiple objects in history and changes - #478

Draft
brainexe wants to merge 2 commits into
mainfrom
md_multiple_history
Draft

brainexe wants to merge 2 commits into
mainfrom
md_multiple_history

Conversation

@brainexe

@brainexe brainexe commented Oct 9, 2026 •

Copy link
Copy Markdown
Member
  • history view accepts multiple object_id/hostname params
  • add hostname column linking to inspect page
  • fix XSS

- history view accepts multiple object_id/hostname params
- add hostname column linking to inspect page
- changes command/view use all selected objects
- fix empty "Time Since" and recreate object_id on deleted rows

@kofrezo kofrezo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like it too much. I think it bloats the already bloated history view and makes it harder to read. Changes is fine as it does not change the display much. But if people find it useful I won't complain.

But lets at least tackle the code changes.

Comment thread packages/serveradmin/serveradmin/serverdb/views.py Outdated
Comment thread packages/serveradmin/serveradmin/serverdb/views.py Outdated
Comment thread packages/serveradmin/serveradmin/servershell/static/js/servershell/command.js Outdated
Comment thread packages/serveradmin/serveradmin/serverdb/views.py Outdated
@brainexe brainexe changed the title servershell: support multiple objects in history and changes DRAFT: servershell: support multiple objects in history and changes Oct 12, 2026
@kofrezo
kofrezo marked this pull request as draft October 12, 2026 14:19
@kofrezo kofrezo changed the title DRAFT: servershell: support multiple objects in history and changes servershell: support multiple objects in history and changes Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants