docs(onchain-clients): remove empty "Fetching the Current Block Number" section - #668
Open
callumweb3 wants to merge 1 commit into
Open
callumweb3 wants to merge 1 commit into
callumweb3 wants to merge 1 commit into
Conversation
…r" section ## What `onchain-clients.mdx` (lines ~38–41) promises a code snippet but has none — between the intro line and `## Viem` there is no code block. ## Why remove The same call is already documented in step 3 of both client sections: - Ethers.js: `await provider.getBlockNumber()` - Viem: `await client.getBlockNumber()` So the section is a duplicate of step 3 and adds nothing new. ## Change Remove the empty heading + promise line. No info is lost. ## Alternative If a standalone example is preferred, see PR #<номер_первого_PR>, which fills the section. Only one should be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
onchain-clients.mdxpromises a code snippet but has none - between the intro line and## Viemthere is no code block.Why remove
The same call is already documented in step 3 of both client sections:
await provider.getBlockNumber()await client.getBlockNumber()So the section is a duplicate of step 3 and adds nothing new.
Change
Remove the empty heading + promise line. No info is lost.