Repository navigation
fix source map error and added tool-versions - #936
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Ready to approve
The changes are small, consistent with the stated goal, and the updated sourcemap parsing logic addresses the reported failure mode without introducing new risk.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR improves the reliability of the post-test source map verification step and adds explicit tool/runtime version metadata to better align local development with CI expectations.
Changes:
- Hardened
scripts/check-sourcemaps.mjsto tolerate non-JSON preamble output fromnpm pack --jsonbefore parsing the report. - Added Node/NPM
enginesconstraints inpackage.json. - Added
.tool-versionsto pin the Node.js version used by local tool managers (e.g., asdf).
File summaries
| File | Description |
|---|---|
| scripts/check-sourcemaps.mjs | Makes npm pack JSON parsing resilient to extra stdout content so the sourcemap check doesn’t fail spuriously. |
| README.md | Updates all-contributors badge count and adds a contributor entry. |
| package.json | Declares expected Node/NPM versions via engines to align with CI runtime. |
| .tool-versions | Pins Node.js version for local toolchain synchronization. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed source map error in post-test script and added .tool-versions and engines key in package.json so ideally we are in sync with what tools are being used in CI