Skip to content

fix source map error and added tool-versions - #936

Merged
GantMan merged 2 commits into
masterfrom
jonmajor/fix-source-maps-parse-error
Aug 3, 2026
Merged

GantMan merged 2 commits into
masterfrom
jonmajor/fix-source-maps-parse-error

Conversation

@jonmajorc

Copy link
Copy Markdown
Contributor

Fixed source map error in post-test script and added .tool-versions and engines key in package.json so ideally we are in sync with what tools are being used in CI

@jonmajorc jonmajorc self-assigned this Aug 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The changes are small, consistent with the stated goal, and the updated sourcemap parsing logic addresses the reported failure mode without introducing new risk.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR improves the reliability of the post-test source map verification step and adds explicit tool/runtime version metadata to better align local development with CI expectations.

Changes:

  • Hardened scripts/check-sourcemaps.mjs to tolerate non-JSON preamble output from npm pack --json before parsing the report.
  • Added Node/NPM engines constraints in package.json.
  • Added .tool-versions to pin the Node.js version used by local tool managers (e.g., asdf).
File summaries
File Description
scripts/check-sourcemaps.mjs Makes npm pack JSON parsing resilient to extra stdout content so the sourcemap check doesn’t fail spuriously.
README.md Updates all-contributors badge count and adds a contributor entry.
package.json Declares expected Node/NPM versions via engines to align with CI runtime.
.tool-versions Pins Node.js version for local toolchain synchronization.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@GantMan
GantMan merged commit c413b4e into master Aug 3, 2026
10 checks passed
@GantMan
GantMan deleted the jonmajor/fix-source-maps-parse-error branch August 3, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants