Skip to content

Placate ruff 0.16.5 #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Aug 28, 2026
Merged

Placate ruff 0.16.5 #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b7ce9
Placate ruff 0.16.5
inducer Aug 28, 2026
7233266
Update baseline
inducer Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 30 additions & 134 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,54 +97,6 @@
"lineCount": 1
}
},
{
"code": "reportUnknownParameterType",
"range": {
"startColumn": 23,
"endColumn": 27,
"lineCount": 1
}
},
{
"code": "reportMissingParameterType",
"range": {
"startColumn": 23,
"endColumn": 27,
"lineCount": 1
}
},
{
"code": "reportUnknownParameterType",
"range": {
"startColumn": 29,
"endColumn": 33,
"lineCount": 1
}
},
{
"code": "reportMissingParameterType",
"range": {
"startColumn": 29,
"endColumn": 33,
"lineCount": 1
}
},
{
"code": "reportUnknownParameterType",
"range": {
"startColumn": 40,
"endColumn": 44,
"lineCount": 1
}
},
{
"code": "reportMissingParameterType",
"range": {
"startColumn": 40,
"endColumn": 44,
"lineCount": 1
}
},
{
"code": "reportUnknownVariableType",
"range": {
Expand Down Expand Up @@ -19343,14 +19295,6 @@
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 12,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
Expand Down Expand Up @@ -19647,22 +19591,6 @@
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 12,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 12,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
Expand All @@ -19687,14 +19615,6 @@
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 12,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
Expand All @@ -19711,14 +19631,6 @@
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 16,
"endColumn": 43,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
Expand Down Expand Up @@ -22274,64 +22186,56 @@
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 12,
"endColumn": 66,
"lineCount": 1
"startColumn": 21,
"endColumn": 68,
"lineCount": 2
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 13,
"endColumn": 37,
"startColumn": 23,
"endColumn": 47,
"lineCount": 1
}
},
{
"code": "reportAttributeAccessIssue",
"range": {
"startColumn": 23,
"endColumn": 37,
"startColumn": 33,
"endColumn": 47,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 39,
"endColumn": 63,
"startColumn": 49,
"endColumn": 73,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 16,
"endColumn": 47,
"lineCount": 2
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 17,
"endColumn": 42,
"startColumn": 13,
"endColumn": 38,
"lineCount": 1
}
},
{
"code": "reportAttributeAccessIssue",
"range": {
"startColumn": 27,
"endColumn": 42,
"startColumn": 23,
"endColumn": 38,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 20,
"endColumn": 44,
"startColumn": 40,
"endColumn": 64,
"lineCount": 1
}
},
Expand All @@ -22354,64 +22258,56 @@
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 12,
"endColumn": 71,
"lineCount": 1
"startColumn": 21,
"endColumn": 59,
"lineCount": 2
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 13,
"endColumn": 37,
"startColumn": 23,
"endColumn": 47,
"lineCount": 1
}
},
{
"code": "reportAttributeAccessIssue",
"range": {
"startColumn": 23,
"endColumn": 37,
"startColumn": 33,
"endColumn": 47,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 39,
"endColumn": 68,
"startColumn": 49,
"endColumn": 78,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 16,
"endColumn": 42,
"lineCount": 2
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 17,
"endColumn": 38,
"startColumn": 13,
"endColumn": 34,
"lineCount": 1
}
},
{
"code": "reportAttributeAccessIssue",
"range": {
"startColumn": 27,
"endColumn": 38,
"startColumn": 23,
"endColumn": 34,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 20,
"endColumn": 39,
"startColumn": 36,
"endColumn": 55,
"lineCount": 1
}
},
Expand Down
2 changes: 1 addition & 1 deletion contrib/fortran-to-opencl/translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,7 @@ def end_block():
(current_cond, cgen.block_if_necessary(
self.map_statement_list(current_body))))

del current_body[:]
current_body.clear()

from fparser.statements import Else, ElseIf
i = 0
Expand Down
10 changes: 2 additions & 8 deletions pyopencl/characterize/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,13 @@ class CLCharacterizationWarning(UserWarning):

@memoize
def has_double_support(dev: cl.Device):
for ext in dev.extensions.split(" "):
if ext == "cl_khr_fp64":
return True
return False
return any(ext == "cl_khr_fp64" for ext in dev.extensions.split(" "))


def has_amd_double_support(dev: cl.Device):
""""Fix to allow incomplete amd double support in low end boards"""

for ext in dev.extensions.split(" "):
if ext == "cl_amd_fp64":
return True
return False
return any(ext == "cl_amd_fp64" for ext in dev.extensions.split(" "))


def reasonable_work_group_size_multiple(
Expand Down
3 changes: 1 addition & 2 deletions pyopencl/elementwise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,7 @@ def __call__(self,
start = range.start
if start is None:
start = 0
invocation_args.append(start)
invocation_args.append(range.stop)
invocation_args.extend((start, range.stop))
if range.step is None:
step = 1
else:
Expand Down
19 changes: 8 additions & 11 deletions pyopencl/invoker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ def generate_generic_arg_handling_body(num_args):
else:
gen_indices_and_args = []
for i in range(num_args):
gen_indices_and_args.append(i)
gen_indices_and_args.append(f"arg{i}")
gen_indices_and_args.extend((i, f"arg{i}"))

gen(f"self._set_arg_multi("
f"({', '.join(str(i) for i in gen_indices_and_args)},), "
Expand Down Expand Up @@ -116,8 +115,7 @@ def add_buf_arg(arg_idx, typechar, expr_str):
arg_var = "arg%d" % arg_idx

if arg_type is None:
gen_indices_and_args.append(cl_arg_idx)
gen_indices_and_args.append(arg_var)
gen_indices_and_args.extend((cl_arg_idx, arg_var))
cl_arg_idx += 1
gen("")
continue
Expand All @@ -135,8 +133,7 @@ def add_buf_arg(arg_idx, typechar, expr_str):
"'queues for all arrays must match the queue supplied "
"to enqueue'")

gen_indices_and_args.append(cl_arg_idx)
gen_indices_and_args.append(f"{arg_var}.base_data")
gen_indices_and_args.extend((cl_arg_idx, f"{arg_var}.base_data"))
cl_arg_idx += 1

if arg_type.with_offset:
Expand All @@ -151,8 +148,7 @@ def add_buf_arg(arg_idx, typechar, expr_str):
arg_dtype = np.dtype(arg_type)

if arg_dtype.char == "V":
buf_indices_and_args.append(cl_arg_idx)
buf_indices_and_args.append(arg_var)
buf_indices_and_args.extend((cl_arg_idx, arg_var))
cl_arg_idx += 1

elif arg_dtype.kind == "c":
Expand Down Expand Up @@ -187,9 +183,10 @@ def add_buf_arg(arg_idx, typechar, expr_str):
"Cannot pass complex numbers to kernels.")

else:
buf_indices_and_args.append(cl_arg_idx)
buf_indices_and_args.append(
f"pack('{arg_char}{arg_char}', {arg_var}.real, {arg_var}.imag)")
buf_indices_and_args.extend(
(cl_arg_idx,
f"pack('{arg_char}{arg_char}', {arg_var}.real, {arg_var}.imag)")
)
cl_arg_idx += 1

fp_arg_count += 2
Expand Down
Loading
Loading