Update Node.js to v22 and modernize CI workflow - #1460
Open
drusepth wants to merge 2 commits into
Open
Conversation
yarn install was aborting in CI because postcss-load-config@6 (pulled in by tailwindcss v3) requires Node >= 18 while the workflow pinned Node 14.15.0, leaving webpack uninstalled and failing assets:precompile before any tests ran. - Bump CI to Node 22 with NODE_OPTIONS=--openssl-legacy-provider, which webpack 4's md4 hashing needs on Node 17+ - Add an explicit 'yarn install --frozen-lockfile' step with yarn caching - Update actions/checkout and actions/setup-node off deprecated versions - Run the Tests workflow on pushes/PRs targeting tailwind-redesign, not just master - Align mise.toml with the same Node version and flag for local dev Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017a6kbgVDn4PohPxtdnx9Cs
- Include ActiveJob::TestHelper in DocumentTest so assert_enqueued_with / assert_no_enqueued_jobs are available - Align the document status default test with the schema's intentional default of 'writing' (migration sets default: 2) - SyllablesService: check overrides before the short-word shortcut so 'ion' => 2 is reachable, and count vowel runs of any length as one syllable so 'beautiful' counts as 3 instead of 4 - Relax the concurrent pin toggle test to assert at most one pinned image; toggling an already-pinned image can legitimately land as an unpin, so 'exactly one' was racy Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017a6kbgVDn4PohPxtdnx9Cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed:
mise.tomland GitHub Actions workflowactions/checkout@v4,actions/setup-node@v4)yarn install --frozen-lockfilestep to CINODE_OPTIONS: --openssl-legacy-providerenvironment variable for webpack 4 compatibility with Node 17+tailwind-redesignbranch to run tests in CI pipeline alongside master@indentlabs/contributors
https://claude.ai/code/session_017a6kbgVDn4PohPxtdnx9Cs