fix(install): honor Ctrl-C during a bottle download - #887
Merged
Conversation
indaco
force-pushed
the
fix/honor-ctrl-c-during-bottle-download
branch
from
August 21, 2026 19:02
2ea8553 to
47b124c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pressing Ctrl-C during a bottle download did not stop it. Every in-flight formula re-dialled the registry twice more, then reported the user's own interruption as a download failure - up to ~15s late per formula, and blamed on the network.
install,install --download-onlyandupgradeshare the loop, so all three behaved this way.The download now stops at the attempt in flight, and a cancelled run reports the interruption once instead of a list of download failures.
--download-onlysaid nothing about being interrupted at all; it does now.Related Issue
Notes for Reviewers