fix(tap): treat every spelling of a tap as the one tap brew treats it as - #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mt install user/homebrew-tap/formulafailed on a tap thatbrew installhandles fine, and two spellings of one tap produced two registry rows with independent pins - somt untapmissed across spellings, andmt list --tapandmt outdated --tapdisagreed on the same data.Tap slugs now fold to the same identity brew uses, wherever one enters, and a migration reunites rows already stored as typed. Explicit
--repo/--urlregistrations are left alone.Related Issue
Notes for Reviewers
taps.nameis UNIQUE, so folding can genuinely collide. Within one forge it keeps the row that can fetch, else the one carrying a real pin, else the oldest. Across forges it keeps both untouched -homebrew-is a GitHub convention and says nothing about a repo of that name elsewhere, so those are two taps, not one.