fix(net): stop failing a cask install on a blip the download would have retried - #881
Merged
Merged
Conversation
…ve retried The HEAD walk that classifies a cask's artifact had no retry at all, so one reset connection was a hard install failure even though the download that follows would have retried the same hop three times. The download's wrapper had the opposite flaw: it retried every error, spending the full backoff before re-reporting a spent hop budget, a malformed redirect or an unparseable url. Both walks now share one rule - retry the transport, surface what the response already decided. The redirect decision and the classification walk each return a closed error set, so the split is derived from those sets rather than a hand written list, and the cask installer maps them exhaustively: a cancelled walk is no longer reported as a dead network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A cask with an extensionless URL is classified by a HEAD walk before it is downloaded, and that walk had no retry - so a single reset connection failed the install outright, even though the download that follows would have retried the same hop three times. The download had the opposite flaw: it retried anything, burning the full backoff on failures no second attempt could change - a spent redirect budget, a malformed redirect, an unparseable URL.
Both walks now retry the transport and surface what the response already decided. A Ctrl-C during classification is no longer reported as a dead network either.
Related Issue
Notes for Reviewers