fix(update): run the exact cosign the trust guard approved - #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mt version updatecould check a release signature with acosignthe trust guard never approved. The guard vetted one binary and the spawn resolved another, so a shim dropped inside malt's own prefix - a directory every installed package can write to - could rubber-stamp the update. The guard now hands the resolved path straight to the spawn, and a candidate it cannot resolve is skipped rather than trusted.Related Issue
Notes for Reviewers
cosignreached through a symlink is now executed by its resolved target rather than the link. That is deliberate: the link is what an attacker in the prefix would control.PATHentry no longer fails an update that a later entry would have satisfied. Skipping stays safe because the spawn only ever runs a candidate this walk returned and vetted.