fix(net): stop passing off a failed artifact-URL resolution as a successful one - #877
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An extensionless cask URL is resolved by walking redirects with a HEAD request; where that walk lands is what picks the artifact type,
.pkgincluded.The walk could lie twice. It treated any status from 301 to 308 as a redirect, so 304, 305 and 306 moved it off the real URL. And a walk that failed - dead origin, dead hop, unusable
Location- returned however far it got, so the installer classified an untouched URL and told the user "Unsupported cask format" when the network was simply down.Now only real redirects are followed, and a walk that cannot finish is an error the installer reports for what it is.
Related Issue
Notes for Reviewers