Skip to content

Move the settings to Kodi's current format, with help texts - #396

Open
im85288 wants to merge 2 commits into
masterfrom
feature/settings-help
Open

im85288 wants to merge 2 commits into
masterfrom
feature/settings-help

Conversation

@im85288

@im85288 im85288 commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Fixes #395.

Kodi's settings window has a help area for the focused setting. Up Next's settings used the old format, which can't fill it, so it always said "No information available" and every explanation had to fit in the label. Skins such as Arctic Fuse 3 cut those long labels off.

Change

  • settings.xml now uses Kodi's version 1 settings format (supported since Kodi 19). Setting ids, types, defaults and ranges are unchanged, so saved values carry over. The five developer test buttons get ids, which the new format needs.
  • Every setting has a help string (30900–30923). Binge mode's grey note (30651) becomes its help text.
  • 14 long English labels are shortened, for example "Default action when nothing selected" becomes "When the countdown ends".
  • The still-watching settings are grouped under "Are you still watching?" (30653). The countdown and skip separators become group headings.
  • The eq(-N,false) row offsets become named dependencies (on bingeMode, selectOpensPlaybackControls, bedtimeEnabled, customAutoPlayTime, enableSkipSegments).

Translations

  • Other languages keep their current text under the new msgid until their translators shorten it, so msgcmp still matches.
  • French labels are shortened here, since French is the language of the report. @casebtwo, could you check the French wording?
  • The 26 new strings show in English until translated.
  • #30651 loses its [COLOR gray] tags in every language, since it's help text now.

Tested in Kodi 21.3 (macOS)

  • All four pages open with no errors in the log.
  • The help text shows for each setting, and the group headings and indented sub-settings display.
  • Values saved in the old format came through: Simple style, Binge mode on, 5 episodes, bedtime 22, a 45 s countdown for all episodes, skipping off.
  • The greyed-out and hidden rules all react when values change: Binge mode greys out the countdown action and the Skip button, the length sliders follow "Vary by episode length", the auto-skip options follow the Skip button, and the bedtime time follows bedtime.
  • OK saves the changes.
  • The test buttons still open their windows.

Tests: tests/test_settings.py checks the new format:

  • every setting has an English label and help;
  • labels stay short (36 characters);
  • dependencies and parents name real settings;
  • every setting the code reads exists;
  • 30651 carries no colour tags.

The Binge mode tests now check named dependencies. 499 tests pass locally, and pylint and flake8 are clean.

🤖 Generated with Claude Code

Kodi's settings window has a help area for the focused setting, but the
old settings format can't fill it, so it always said "No information
available" and every explanation had to fit in the label. Skins such as
Arctic Fuse 3 cut those long labels off (#395).

settings.xml now uses the version 1 format. Setting ids, types, defaults
and ranges are unchanged, so saved values carry over. The test buttons
get ids of their own, which the new format needs.

- Every setting has a help string (30900-30923). Binge mode's grey note
  (30651) is now its help text.
- Long English labels are shortened (14 of them). Other languages keep
  their current text under the new msgid until translators shorten it;
  French is shortened here, since it's the language from the report.
- The "still watching" settings are grouped under "Are you still
  watching?" (30653). The countdown and skip separators become group
  labels.
- The "eq(-N,false)" offsets become named dependencies on bingeMode,
  selectOpensPlaybackControls, bedtimeEnabled, customAutoPlayTime and
  enableSkipSegments.

tests/test_settings.py checks the new file: every setting has an English
label and help, labels stay short, dependencies and parents name real
settings, and every setting the code reads exists.

Fixes #395

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge, with the previous test-coverage gap fixed.

Summary

Moves settings to Kodi’s current format, adds help text, and shortens labels.

  • Up Next settings show shorter labels, useful help, and clearer groups.

Reviews (2) · Last reviewed commit: "Check the auto-skip settings read throug..." · Reviewed by Greptile

Comment thread tests/test_settings.py Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@casebtwo

casebtwo commented Nov 17, 2026 •

Copy link
Copy Markdown

Thanks for your work,
the French wording is ok for me
I've opened a pull request with the complete French translation, so the new help strings and group headings now show in French too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shorten setting labels and move the explanations to the help area

2 participants