Skip to content

Stab initially at making THG ESDG work. - #854

Closed
hyperSuperCube wants to merge 1 commit into
mainfrom
esdg-trial
Closed

Stab initially at making THG ESDG work.#854
hyperSuperCube wants to merge 1 commit into
mainfrom
esdg-trial

Conversation

@hyperSuperCube

@hyperSuperCube hyperSuperCube commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

First attempt to resurrect ESDG implementation by THG.

Depends on inducer/grudge#305

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants