Skip to content

Stop using obsolete URI.regexp for validation #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcoyne merged 1 commit into from
Nov 6, 2025
Merged

Stop using obsolete URI.regexp for validation #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/iiif/v3/abstract_resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,12 @@ def define_accessor_methods(*keys, &validation)
end

private

def validate_uri(val, key)
unless val.kind_of?(String) && val =~ /\A#{URI::regexp}\z/
m = "#{key} value must be a String containing a URI for #{self.class}"
raise IIIF::V3::Presentation::IllegalValueError, m
end
raise ArgumentError if URI(val).scheme.nil?
rescue URI::Error, ArgumentError
m = "#{key} value must be a String containing a URI for #{self.class}"
raise IIIF::V3::Presentation::IllegalValueError, m
end

end
Expand Down