Filter tracks - #1724
Merged
Merged
Conversation
…include sample filtering for multi-sample tracks (VariantTrack)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a track filtering system that allows users to filter both tracks and samples within variant tracks based on attributes. It replaces the existing abstract filtering framework with a concrete implementation that supports both track-level and sample-level filtering.
- Refactors the abstract
FilterandFilterElementclasses into concrete implementations - Adds support for filtering samples within
VariantTrackthrough a newTrackFilterEvent - Replaces the complex UI components with a simplified
TrackFilterDialog
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| VariantTrack.java | Adds sample filtering capability and event handling for filter changes |
| Filter.java | Converts from abstract to concrete class with track and sample evaluation methods |
| FilterElement.java | Simplifies from abstract to concrete class with unified evaluation logic |
| TrackFilterDialog.java | New simplified dialog for configuring filters |
| FilterTracksMenuAction.java | Streamlined to use new dialog and event system |
| TrackFilterEvent.java | New event class for communicating filter changes |
| Multiple deleted files | Removes old abstract filtering components and UI classes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.