Skip to content

feat: re-consolidate html sanitizing - #11641

Open
noralmaani wants to merge 11 commits into
ietf-tools:mainfrom
noralmaani:nh3
Open

feat: re-consolidate html sanitizing#11641
noralmaani wants to merge 11 commits into
ietf-tools:mainfrom
noralmaani:nh3

Conversation

@noralmaani

Copy link
Copy Markdown
Contributor

Uses nh3 for html sanitization. This uses two linkers: a markdown extension and Django's urlize filter for templates, dropping the linkify filter that used bleach's linker for both contexts.

Introduces a nooperner noferrer rel attribute to links as the default nh3 param.

Fixes #10138. This also renders mailman URLs and fixes #10120.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.71%. Comparing base (e756948) to head (c8d1fd2).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ietf/utils/markdown.py 89.36% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11641   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         335      335           
  Lines       45256    45257    +1     
=======================================
+ Hits        40151    40152    +1     
  Misses       5105     5105           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace datatracker's use of bleach Linkifying URLs with an email address in them fails

1 participant