chore(dev): allow passwordless login for dev - #11573
Draft
jennifer-richards wants to merge 1 commit into
Draft
Conversation
Completely bypasses password check instead of counting on the password being replaced in the DB dump
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11573 +/- ##
==========================================
- Coverage 88.65% 88.63% -0.03%
==========================================
Files 333 333
Lines 44966 44984 +18
==========================================
+ Hits 39866 39871 +5
- Misses 5100 5113 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely bypasses password check instead of counting on the password being replaced in the DB dump. In a world where Datatracker uses OIDC for login and no longer maintains its own passwords, this will continue to allow login. To make this work, we'll also need to expose the traditional Django login instead of or parallel to the OIDC login views.
Continues to allow login using any email address.
To prevent accidental use in production, only configures the backend via
settings_local.pyin dev environments for now. A guard in the backend class throws an exception if it's used in other than development and test modes. That will prevent accidental use, even if we deploy this to the sandbox k8s environment where a misconfiguration could more plausibly enable this for production.