Skip to content

Fix build after blake2 0.11 bump; drop dead MinIO mc install from CI - #340

Merged
iesahin merged 2 commits into
mainfrom
fix/blake2-0.11-build
Oct 26, 2026
Merged

iesahin merged 2 commits into
mainfrom
fix/blake2-0.11-build

Conversation

@iesahin

@iesahin iesahin commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

main stopped compiling after the Dependabot group bump in #339, which moved blake2 from 0.10 to 0.11:

error[E0283]: type annotations needed
   --> core/src/types/xvcdigest/mod.rs:112:32
112 |         Blake2s::digest(bytes).into()

blake2 0.11 makes Blake2s generic over its output size. The new hybrid_array output type converts into arrays of several sizes, so .into() into [u8; 32] can't work out the size any more.

CI was also failing for a separate reason. The "Install required packages" step downloads MinIO's mc client, and dl.min.io now returns 410 Gone for both the Linux binary and the Homebrew formula. Both test jobs failed there before compiling anything.

Changes

  • core: use the fixed-size Blake2s256 alias instead of Blake2s. It's the same BLAKE2s-256 output as before, so existing digests and cache paths stay the same.
  • core: drop the sha2::Digest as _ import. blake2 and sha2 now share digest 0.11, so this import was unused and caused a warning.
  • CI: stop installing mc in rust.yml (Linux and macOS jobs) and nightly.yml. Nothing in this repo uses it since the MinIO storage tests moved to xvc-mono.

Testing

  • cargo build --workspace --all-targets succeeds.
  • cargo test -p xvc-core passes.
  • Both workflow files still parse as valid YAML, and nothing under .github/ mentions mc or min.io any more.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FbVbBU3xkMNb47og9bmESm

📄 PDF — updated 2026-10-26 19:32 UTC

blake2 0.11 makes Blake2s generic over output size, and `.into()`
into [u8; 32] can no longer infer it. Use the fixed-size Blake2s256
alias (same BLAKE2s-256 output). Drop the now-redundant sha2 Digest
import since blake2 and sha2 share digest 0.11.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FbVbBU3xkMNb47og9bmESm

iesahin commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

CI is red because of the CI environment, not this diff. Test on Linux (stable) and Test on macOS (stable) both fail in the "Install required packages" step, before any Rust is compiled:

  • Linux: wget https://dl.min.io/client/mc/release/linux-amd64/mc → ERROR 410: Gone
  • macOS: brew install minio/stable/mc → Failed to download resource "mc (RELEASE.2025-08-13T08-35-41Z)" … curl: (56) … error: 410

MinIO has removed the mc client downloads. The URL still returns 410 on a retry, so this isn't a flaky download. Every PR will fail at this step until the workflow changes. I couldn't find an existing fix in main or another PR.

Nothing in this repo uses mc any more, since the MinIO storage tests moved to xvc-mono's xvc-test. Proposed fix: remove the install from .github/workflows/rust.yml.

@@ Test on macOS: Install required packages
           brew install python3
-          brew install minio/stable/mc
           brew install rclone
@@ Test on Linux: Install required packages
           sudo dpkg -i lsd_0.23.1_amd64.deb
-          # Install minio client
-          wget https://dl.min.io/client/mc/release/linux-amd64/mc
-          chmod +x mc
-          sudo mv mc /usr/local/bin/

.github/workflows/nightly.yml (lines 130–132) uses the same download and will fail the same way.


Generated by Claude Code

dl.min.io now returns 410 Gone for the mc binary and the Homebrew
formula, failing the "Install required packages" step on Linux and
macOS before anything is built. Nothing in this repo uses mc since
the MinIO storage tests moved to xvc-mono, so drop the install from
rust.yml and nightly.yml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FbVbBU3xkMNb47og9bmESm
@iesahin iesahin changed the title core: fix build after blake2 0.11 bump Fix build after blake2 0.11 bump; drop dead MinIO mc install from CI Oct 26, 2026
@iesahin
iesahin merged commit 095722e into main Oct 26, 2026
6 checks passed
@iesahin
iesahin deleted the fix/blake2-0.11-build branch October 26, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants