Repository navigation
Fix build after blake2 0.11 bump; drop dead MinIO mc install from CI - #340
Merged
Merged
Conversation
blake2 0.11 makes Blake2s generic over output size, and `.into()` into [u8; 32] can no longer infer it. Use the fixed-size Blake2s256 alias (same BLAKE2s-256 output). Drop the now-redundant sha2 Digest import since blake2 and sha2 share digest 0.11. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FbVbBU3xkMNb47og9bmESm
Owner
Author
|
CI is red because of the CI environment, not this diff.
MinIO has removed the Nothing in this repo uses @@ Test on macOS: Install required packages
brew install python3
- brew install minio/stable/mc
brew install rclone
@@ Test on Linux: Install required packages
sudo dpkg -i lsd_0.23.1_amd64.deb
- # Install minio client
- wget https://dl.min.io/client/mc/release/linux-amd64/mc
- chmod +x mc
- sudo mv mc /usr/local/bin/
Generated by Claude Code |
dl.min.io now returns 410 Gone for the mc binary and the Homebrew formula, failing the "Install required packages" step on Linux and macOS before anything is built. Nothing in this repo uses mc since the MinIO storage tests moved to xvc-mono, so drop the install from rust.yml and nightly.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FbVbBU3xkMNb47og9bmESm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainstopped compiling after the Dependabot group bump in #339, which movedblake2from 0.10 to 0.11:blake20.11 makesBlake2sgeneric over its output size. The newhybrid_arrayoutput type converts into arrays of several sizes, so.into()into[u8; 32]can't work out the size any more.CI was also failing for a separate reason. The "Install required packages" step downloads MinIO's
mcclient, anddl.min.ionow returns410 Gonefor both the Linux binary and the Homebrew formula. Both test jobs failed there before compiling anything.Changes
core: use the fixed-sizeBlake2s256alias instead ofBlake2s. It's the same BLAKE2s-256 output as before, so existing digests and cache paths stay the same.core: drop thesha2::Digest as _import.blake2andsha2now sharedigest0.11, so this import was unused and caused a warning.mcinrust.yml(Linux and macOS jobs) andnightly.yml. Nothing in this repo uses it since the MinIO storage tests moved toxvc-mono.Testing
cargo build --workspace --all-targetssucceeds.cargo test -p xvc-corepasses..github/mentionsmcormin.ioany more.🤖 Generated with Claude Code
https://claude.ai/code/session_01FbVbBU3xkMNb47og9bmESm
📄 PDF — updated 2026-10-26 19:32 UTC