Draw SVG texts with iced fontdb - #3393
Open
OlivierLemoine wants to merge 4 commits into
Open
Conversation
…nstead of creating a new one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, iced does not render texts in svg with fonts loaded with
iced::Application::font(), but only with system fonts. This means that on the web, there is no text at all.This PR uses iced's font_system to load the fonts and thus, sharing the custom ones with the svg renderer. This does work on the web as well.
However, the feature
iced_renderer/svg-textis needed, and I don't know if the right approach is to make it dependent onsvgor create a new one entirely.