Repository navigation
CMake configuration overhaul #133
Description
Activity
Arguments for going to cmake > 3.15: https://cmake.org/cmake/help/latest/policy/CMP0094.html#policy:CMP0094
#132 (comment) for two more points:
- Use
FindPythonto detect python - Make sure the
BUILD_TESTINGoption is considered for all tests
- Use
Some more considerations for the choice of the minimum required cmake version:
#132 (comment)This remark fits to this issue, but feel free to open a separate one: I noticed that the two files LCIOConfig.cmake and LCIOConfigVersion.cmake end up after 'make install' in <CMAKE_INSTALL_PREFIX> directly, while for most (maybe all?) cmake built projects I know they are installed/written to <CMAKE_INSTALL_PREFIX>/lib/cmake
I would find it more consistent for these files to end up of there.When I build latest version v2-20-2,
LCIOConfig.cmakeis placed underlib/cmake/LCIO/LCIOConfig.cmakeandSIOTargets.cmakegoes intolib/cmake/SIO/SIOTargets.cmake(notice the different directories). This leads to the problem whenLCIOConfig.cmakearound line 75 looks forSIOTargets.cmakein the lineinclude("${CMAKE_CURRENT_LIST_DIR}/SIOTargets.cmake"). Of course the easiest way for fix would be to hard-code SIO path asinclude("${CMAKE_CURRENT_LIST_DIR}/.../SIO//SIOTargets.cmake")but I'm sure, there is a more elegant way, I'm just not so familiar with CMake.
The cmake configuration of several ilcsoft packages is pretty old and could potentially profit from exploiting newer cmake functionalities and in general newer cmake paradigms, e.g. target based configurations. Since LCIO is at the very base of everything, it could serve as a good starting point to check what would need changing and could then serve as an example for other packages as well.
A few points that should be decided/considered beforehand:
XXX_LIBRARIES,XXX_INCLUDE_DIRSapproach can co-exist (see, e.g. SIO, so that it should be possible to update this package by package without breaking everything while updating.A more modern cmake configuration has the potential to make some of the cmake macros that are part of ilcsoft obsolete, as cmake can now handle many things for which these macros were originally designed by itself. To which degree we can remove these macros is hard to estimate and will be something we find out along the way.
Other TODOs (keeping them here because then they show up as X of Y in the overview):
FindPythonto detect pythonBUILD_TESTINGoption is considered for all tests