Announcement fixes cherry picked from pr 746 - #780

Merged

ArneBab merged 6 commits into

nextfrom

announcement-fixes-cherry-picked-from-PR-746

Nov 5, 2022

Commits on Jun 14, 2022

PeerNode.shouldAcceptAnnounce never added uid to runningAnnounceUIDs

Eleriseth
authored and
ArneBab
committed
917db65
Document what these methods are for.

toad
authored and
ArneBab
committed
bc03e3e
Fix return value of completedAnnounce(), thanks Eleriseth.

toad
authored and
ArneBab
committed
abd9d7e
PeerNode.completedAnnounce was completely broken [ this is the actual bug fix, not the cleanup ]

Eleriseth
authored and
ArneBab
committed
1a09409
Cleanup, thanks Eleriseth, this is the rest of "PeerNode.completedAnnounce was completely broken", not including the stuff about double announcement (which isn't relevant).

Eleriseth
authored and
ArneBab
committed
00038c5
Fix unnecessary array copying. Add error messages for exceptional cases. Don't assert. Not the same as Eleriseth's patch, but thanks Eleriseth for pointing out the issue.

toad
authored and
ArneBab
committed
2f4a3e5