prepare version switch with Java 17 - #1138
Open
ArneBab wants to merge 1 commit into
Open
Conversation
Split shares for the UPDATE_URI have been sent to core devs as contingency.
Bombe
requested changes
Aug 17, 2026
| public final static String UPDATE_URI = "USK@rW3wdla3fvFIBcMyl1xyd8umjiQQaZaQ-UqaZQCDOMQ,FfihUHiGuHNgNchv5paweQV5oHD0k4~MdlS-eNXcDF0,AQACAAE/jar/" | ||
| + Version.buildNumber(); | ||
|
|
||
| /** The URI for post-TRANSITION_VERSION builds' freenet.jar on EoL JVMs. */ |
Contributor
There was a problem hiding this comment.
Now we have two “post-TRANSITION_VERSION builds” and I think we should update both of these comments to be more explicit about what they are. 🙂
| assertTrue(JVMVersion.isEOL("1.5")); | ||
| assertTrue(JVMVersion.isEOL("1.7.0_65")); | ||
| assertTrue(JVMVersion.isEOL("1.7")); | ||
| assertTrue(JVMVersion.isEOL("10")); |
Contributor
There was a problem hiding this comment.
This name of this method and the testRecentEnoughWarning method are terrible confusing, as e.g. Java 10 is in both of them. Is it too old or recent enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split shares for the UPDATE_URI have been sent to core devs as contingency.