Repository navigation
Support doNotSuggest - #163
Merged
jdesrosiers merged 3 commits intoOct 23, 2026
Merged
Conversation
Annotations from a parent's alternatives are location annotations for the property, so one alternative's doNotSuggest hides it until a discriminant rules that alternative out. Cover the discriminated cases and document the gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It's only used there, so it belongs with the feature rather than the shared completions module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jdesrosiers
approved these changes
Oct 23, 2026
jdesrosiers
left a comment
jdesrosiers
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I mostly just added a few tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for
doNotSuggestkeyword in property completions.A property whose schema sets
doNotSuggest: trueis no longer suggested, while remaining fully valid. It is done by reusing the annotations it already used for deprecation.Works through
$refandallOf; adoNotSuggestinside ananyOf/oneOfalternative doesn't hide the property (matching VS Code, which only inspects the property's own schema).Closes #162