Skip to content

Fix failure handler registration - #2056

Merged
XWB merged 3 commits into
hwi:masterfrom
PavloRymarovych:master
May 22, 2026
Merged

Fix failure handler registration#2056
XWB merged 3 commits into
hwi:masterfrom
PavloRymarovych:master

Conversation

@PavloRymarovych

Copy link
Copy Markdown
Contributor

There was breaking changes after which failure_handler configuration is ignored and custom auth failure handler is not registered.
In order to fix it, I've implemented failure handler registration similar to original Symfony method in overridden AbstractFactory::createAuthenticationFailureHandler

Related issues:
#2045 #2010 #1999 #1989

@github-actions

Copy link
Copy Markdown

Message to comment on stale PRs. If none provided, will not mark PRs stale

@github-actions github-actions Bot added the Stale label Apr 25, 2026
@github-actions github-actions Bot closed this Apr 30, 2026
@jperdochqu

Copy link
Copy Markdown

Please, is there any reason why it wasn't properly reviewed and merged?

@XWB

XWB commented May 17, 2026

Copy link
Copy Markdown
Member

I suppose the pipeline needs to be fixed before it can be merged.

@XWB XWB reopened this May 17, 2026
@jperdochqu

Copy link
Copy Markdown

@PavloRymarovych take a look on that, please

@github-actions github-actions Bot removed the Stale label May 18, 2026
@PavloRymarovych

Copy link
Copy Markdown
Contributor Author

Checked — the failing php-cs-fixer check is unrelated to this PR. It flags 103 files, none of them touched here. The reported issues (declare(strict_types=1) removals, missing : void return types on setters) already exist on upstream master.

@XWB
XWB merged commit c362e5d into hwi:master May 22, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants