Strip all LOG_* call sites — logging re-tiering baseline#1447
Strip all LOG_* call sites — logging re-tiering baseline#1447ChaoZheng109 wants to merge 1 commit into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c0a7c39 to
e407c3e
Compare
Trim low-signal LOG_* call sites across the runtime and platform layers, keeping the diagnostics that trace program flow or failures: - Flow / lifecycle / summary logs kept at INFO; per-item (per-tensor, per-arg) detail demoted to LOG_DEBUG; failure paths stay LOG_ERROR / LOG_WARN. Loader / device-runner load-path diagnostics kept at their original levels. - AICPU hot paths (per-task / per-scope dispatch loops) carry no logs (codestyle rule 7); DFX collectors keep their buffer-level init/flush diagnostics and telemetry counters. - STRACE, LOG_RUNTIME_FAILURE and ACL logging left untouched. - Log-only support removed with its logs (bookkeeping counters, dump scaffolding); genuine out-of-scope strip collateral restored (unused-parameter removals, blank-line deletions). Rebased onto upstream/main; dense dependency diagnostics follow upstream's debug-only / removed decisions (hw-native-sys#1448), completion follows the polling mechanism (hw-native-sys#1435).
1 participant
Reduce logging footprint (#1428)
Curate
LOG_*call sites across the runtime and platform layers: droplow-signal logs, demote per-item detail to
LOG_DEBUG, and keep thediagnostics that trace program flow or failures.
Net effect vs base (individual call sites; a2a3 / a5 counted separately)
LOG_INFO_V0+ 8LOG_DEBUG+ 5LOG_INFO_V9+ 2LOG_ERROR+ 3LOG_WARN)LOG_DEBUGLOG_INFO_V0→LOG_DEBUG)Curation rules
per-arg) detail demoted to
LOG_DEBUG; failure paths stayLOG_ERROR/LOG_WARN. Loader / device-runner load-path diagnosticskept at their original levels.
(codestyle rule 7); DFX collectors keep their buffer-level init/flush
diagnostics and telemetry counters.
STRACE,LOG_RUNTIME_FAILUREand ACL logging left untouched.scaffolding); out-of-scope strip collateral restored (unused-parameter
removals, blank-line deletions).
Rebased onto
upstream/main; dense dependency diagnostics follow upstream'sdebug-only / removed decisions (#1448), completion follows the polling
mechanism (#1435).