Fix: add A5 early-resolve task hint API#1407
Conversation
- Add the generated-code-compatible hint to A5 task arguments without enabling A2/A3 early-dispatch behavior - Expose the hint through dependency-owning arguments and cover its reset semantics
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds the ChangesEarly Resolve Task Hint
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces the allow_early_resolve task hint to L0TaskArgs and exposes it in L0TaskArgsWithDeps. It also adds corresponding unit tests to verify that the hint is correctly set, reset, and exposed. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
allow_early_resolvehint API to A5L0TaskArgsL0TaskArgsWithDepsand reset it when arguments are recycledThis unblocks the A5 orchestration compilation failure in hw-native-sys/pypto-lib#801.
Testing
61 passed)tensormap_and_ringbuffercoverage (71 passed,2 skipped)-8005)The two hardware-only async-notify demos selected by the simulator-wide command were not counted as simulator coverage. They hard-code
a2a3/a5and fail locally atrtSetDevicebecause no usable device is available.