feat: PancakeSwap CLMM fixes + MasterChef routes (clean branch) by VeXHarbinger · Pull Request #680 · hummingbot/gateway

VeXHarbinger · 2026-08-13T17:35:28Z

Summary

Includes PancakeSwap-focused fixes requested from PR Feat PancakeSwap V3 CLMM fixes, binCount pool-info for all CLMM connectors, extended Ethereum tx polling #646 scope (1,2,3,5)
Includes staked fee collection support and live CLMM fee accrual updates
Adds MasterChef NFT staking endpoints
Adds route registration test coverage for nftStaking endpoints

Endpoints added

POST /connectors/pancakeswap/nftStaking/masterchef-stake
POST /connectors/pancakeswap/nftStaking/masterchef-unstake
POST /connectors/pancakeswap/nftStaking/masterchef-unstake-and-close
POST /connectors/pancakeswap/nftStaking/masterchef-knows-pool

Validation

pnpm build passes
Targeted route test passes

Scope

PancakeSwap-related files only.

greptile-apps · 2026-08-13T17:39:28Z

Greptile Summary

The PR adds PancakeSwap MasterChef staking routes and updates CLMM position, pool, swap, and fee-collection behavior.

Registers four NFT-staking endpoints for staking, unstaking, combined unstake-and-close, and pool registration checks.
Preserves uint256 token IDs as strings across the new staking transaction paths.
Collects trading fees from staked positions directly through the configured MasterChef ABI.
Adds live fee-accrual calculations and optional CLMM bin-distribution data.
Extends route and fee-collection regression coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
src/connectors/pancakeswap/pancakeswap.ts	Adds string-safe MasterChef staking helpers and resolves pid-zero ambiguity through a separate registration query.
src/connectors/pancakeswap/clmm-routes/collectFees.ts	Adds direct ABI-backed fee collection for staked positions and updates non-staked collection probing and fee reporting.
src/connectors/pancakeswap/PancakeswapV3Masterchef.abi.json	Defines the MasterChef contract interface used by staking and direct staked-fee collection.
src/connectors/pancakeswap/nft-staking/masterchef-stake.ts	Adds the MasterChef staking endpoint with token IDs represented as strings.
src/connectors/pancakeswap/nft-staking/masterchef-unstake.ts	Adds the MasterChef unstaking endpoint while preserving token ID precision.
src/connectors/pancakeswap/nft-staking/masterchef-unstake-and-close.ts	Adds the combined unstake-and-close flow with a string token ID passed through both operations.
src/connectors/pancakeswap/nft-staking/masterchef-knows-pool.ts	Reports the pool ID and independently determines registration, including valid pool ID zero.
src/connectors/pancakeswap/clmm-routes/positionInfo.ts	Computes current uncollected fees from live pool fee-growth state.
src/app.ts	Registers the PancakeSwap NFT-staking route group.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Gateway PancakeSwap routes] --> B[CLMM routes]
    A --> C[NFT staking routes]
    C --> D[MasterChef stake]
    C --> E[MasterChef unstake]
    C --> F[Unstake and close]
    C --> G[Pool registration check]
    B --> H[Collect fees]
    H --> I{NFT owner}
    I -->|Wallet| J[Position Manager collect]
    I -->|MasterChef| K[MasterChef collect]
    F --> E
    F --> L[Close CLMM position]

_{Reviews (6): Last reviewed commit: "fix(pancakeswap): use canonical nftStaki..." | Re-trigger Greptile}

greptile-apps · 2026-08-13T17:39:31Z

+  tokenId: Type.Number({
+    description: 'Token ID of the NFT position to unstake and close',
+    examples: [6450873],
+  }),


Numeric token IDs lose precision

When a valid uint256 token ID exceeds Number.MAX_SAFE_INTEGER, Type.Number rounds it before it reaches unstakeNft and closePosition, causing the request to fail against a nonexistent ID or to remove liquidity from and burn a different position. The stake and standalone unstake routes use the same lossy representation, so these identifiers need to remain strings throughout the request and transaction paths.

greptile-apps · 2026-08-13T17:39:31Z

+      if (poolId === 0) {
+        throw new Error(
+          `Pool for position ${tokenId} is not registered in MasterChef. ` +
+            `Only positions in MasterChef-registered pools can be staked.`,
+        );


Pool zero is falsely rejected

When a position belongs to the MasterChef pool registered at pid 0, v3PoolAddressPid returns the valid ID 0 and this branch incorrectly classifies the pool as unregistered, preventing the position from being staked. The masterchef-knows-pool route applies the same nonzero test and consequently reports that pool as unknown.

greptile-apps · 2026-08-13T17:39:32Z

+  const encodedArgs = utils.defaultAbiCoder.encode(
+    ['uint256', 'address', 'uint128', 'uint128'],
+    [positionAddress, walletAddress, UINT128_MAX, UINT128_MAX],
+  );
+  const data = `${MASTER_CHEF_COLLECT_SELECTOR}${encodedArgs.slice(2)}`;
+
+  const txParams = await ethereum.prepareGasOptions(undefined, CLMM_COLLECT_FEES_GAS_LIMIT);
+  const tx = await wallet.sendTransaction({
+    to: masterChefAddress,
+    data,


MasterChef collect calldata mismatches ABI

When fees are collected from a staked NFT, this code sends a hard-coded flat collect(uint256,address,uint128,uint128) call even though the supplied MasterChef ABI implements no matching function, causing the submitted transaction to revert and consume gas instead of collecting fees.

VeXHarbinger · 2026-08-13T18:06:08Z

Addressing found issues

- keep NFT token IDs as strings across stake/unstake routes and connector methods - handle pid=0 correctly via explicit MasterChef pool registration check - replace hard-coded staked collect calldata with ABI-backed harvest() call

greptile-apps · 2026-08-13T18:17:01Z

+  );
+
+  const txParams = await ethereum.prepareGasOptions(undefined, CLMM_COLLECT_FEES_GAS_LIMIT);
+  const tx = await masterChefContract.harvest(positionAddress, walletAddress, txParams);


Harvest leaves trading fees uncollected

When fee collection is requested for a MasterChef-staked NFT, this branch calls harvest, which claims the farming reward rather than collecting the position's token0/token1 trading fees. The endpoint then reports token0/token1 balance deltas—normally zero—while the requested trading fees remain uncollected.

VeXHarbinger · 2026-08-13T18:21:47Z

Addressed Greptile P1 findings in commit a605717.

Numeric token ID precision

tokenId request schemas switched to string for stake/unstake routes
connector methods stakeNft/unstakeNft now accept string IDs

pid=0 false-negative

added explicit isMasterChefPoolRegistered(pool) check using getLatestPeriodInfo(pool)
masterchef-knows-pool now reports known from registration check instead of pid!=0

Staked fee collect calldata mismatch

replaced hard-coded selector payload with ABI-backed MasterChef harvest(tokenId,to) call

Build status: pnpm build passes on branch pancakeswap-bsc-lp.

Use the correct unstake -> NPM collect -> restake sequence for MasterChef-staked NFTs instead of calling harvest(), which only claims farm rewards and leaves trading fees uncollected.

greptile-apps · 2026-08-13T18:31:05Z

+  await pancakeswap.unstakeNft(positionAddress, walletAddress);
+
+  try {
+    collectResult = await collectFees(network, walletAddress, positionAddress);
+  } catch (error: any) {
+    collectError = error;
+  } finally {
+    try {
+      await pancakeswap.stakeNft(positionAddress, walletAddress);


Restake failure leaves NFT unstaked

When withdrawal succeeds but fee collection or restaking fails, this sequence returns an error without restoring the NFT's original MasterChef state, leaving the position unstaked and no longer earning farming rewards.

Restore direct MasterChef fee collection for staked NFTs using a typed collect(uint256,address,uint128,uint128) ABI fragment proven by on-chain tx 0x43fbb08a7e6944ae2a1e9bcfcb1fdb4134aed9acc51b809309daca9103c51e99, avoiding both raw calldata and temporary unstake/restake flow.

greptile-apps · 2026-08-13T18:43:07Z

+
+  const masterChefContract = new Contract(masterChefAddress, MASTER_CHEF_STAKED_COLLECT_ABI, wallet);
+  const txParams = await ethereum.prepareGasOptions(undefined, CLMM_COLLECT_FEES_GAS_LIMIT);
+  const tx = await masterChefContract.collect(positionAddress, walletAddress, UINT128_MAX, UINT128_MAX, txParams);


MasterChef collect selector remains invalid

When fee collection is requested for a MasterChef-staked NFT, this branch submits collect(uint256,address,uint128,uint128), which is absent from the configured MasterChef interface, causing the transaction to revert while consuming gas and leaving the trading fees uncollected.

Latest follow-up fix in ffda583:

aligned the PancakeSwap MasterChef ABI source-of-truth with the deployed staked fee collect interface by adding collect(uint256,address,uint128,uint128) to PancakeswapV3Masterchef.abi.json

updated collectFees.ts to use the configured MasterChef ABI file instead of an inline ABI fragment

preserved the direct staked fee collection path (no unstake/restake fallback)

added regression coverage proving that staked fee collection calls collect() directly and does not call unstakeNft()

Validation:

pnpm build passes

targeted regression test passes:
test/connectors/pancakeswap/clmm-routes/collectFees.test.ts

Additional runtime confirmation:

we observed a successful on-chain MasterChef staked collect transaction using this interface:
0x43fbb08a7e6944ae2a1e9bcfcb1fdb4134aed9acc51b809309daca9103c51e99

- add collect(uint256,address,uint128,uint128) to PancakeswapV3Masterchef.abi.json - use the configured MasterChef ABI as the source of truth in collectFees - add regression coverage that staked fee collection calls collect() directly and never unstakeNft()

Register PancakeSwap nftStaking routes in app.ts and add a /nft-staking alias for the live bot's existing close/rebalance path.

Register only the canonical gateway nftStaking prefix and remove the temporary alias. The live bot has been updated to call the canonical path.

VeXHarbinger added 3 commits August 13, 2026 12:53

fix(pancakeswap): support staked fee collect and live CLMM fee accrual

81353c1

fix(pancakeswap): include PR646 fixes 1/2/3/5 and masterchef routes

d03852d

test(pancakeswap): add nftStaking route registration coverage

f288308

VeXHarbinger mentioned this pull request Aug 13, 2026

Feat PancakeSwap V3 CLMM fixes, binCount pool-info for all CLMM connectors, extended Ethereum tx polling #646

Closed

greptile-apps Bot reviewed Aug 13, 2026

View reviewed changes

fix(pancakeswap): collect staked CLMM fees via unstake flow

6d99ba7

Use the correct unstake -> NPM collect -> restake sequence for MasterChef-staked NFTs instead of calling harvest(), which only claims farm rewards and leaves trading fees uncollected.

greptile-apps Bot reviewed Aug 13, 2026

View reviewed changes

VeXHarbinger added 3 commits August 13, 2026 14:48

fix(pancakeswap): register nft staking runtime routes

05d0c1f

Register PancakeSwap nftStaking routes in app.ts and add a /nft-staking alias for the live bot's existing close/rebalance path.

fix(pancakeswap): use canonical nftStaking route

211e843

Register only the canonical gateway nftStaking prefix and remove the temporary alias. The live bot has been updated to call the canonical path.

Navigation Menu

Uh oh!

Uh oh!

feat: PancakeSwap CLMM fixes + MasterChef routes (clean branch) - #680

feat: PancakeSwap CLMM fixes + MasterChef routes (clean branch)#680
VeXHarbinger wants to merge 9 commits into
hummingbot:developmentfrom
High-Falootin:pancakeswap-bsc-lp

VeXHarbinger commented Aug 13, 2026

Uh oh!

greptile-apps Bot commented Aug 13, 2026 •

edited

Loading

Important Files Changed

Flowchart

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

VeXHarbinger commented Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

VeXHarbinger commented Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Uh oh!

VeXHarbinger Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

VeXHarbinger commented Aug 13, 2026

Summary

Endpoints added

Validation

Scope

Uh oh!

greptile-apps Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

VeXHarbinger commented Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

VeXHarbinger commented Aug 13, 2026

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

VeXHarbinger Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps Bot commented Aug 13, 2026 •

edited

Loading