Give redirect warning close button more area to make it easier to touch on mobile - #2443
Open
ShirleyNekoDev wants to merge 1 commit into
Open
Give redirect warning close button more area to make it easier to touch on mobile#2443ShirleyNekoDev wants to merge 1 commit into
ShirleyNekoDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the close button for the redirect warning a separate CSS "layer" (not really, but you'll see what I mean) and added a padding around the X so that you can hit it easier on mobile.
I also added a localStorage banner suppression which saves the hidden state of the banner (aside from using the redirect.io session stuff).
* As this has already been fixed minutes before I commited my changes, I can remove that part if you want to. ;)
I hope this helps.
Screenshots for different sizes below (outline around button to represent click area, not visible in PR code) :
Btw. this banner close button differs from the unicode "×" used in the mobile app banner below 🤔