Skip to content

fix(log): avoid Array to string conversion warning in SimpleFormatter #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralflang merged 3 commits into from
Jul 11, 2026
Merged

fix(log): avoid Array to string conversion warning in SimpleFormatter #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf2bca7
fix(log): avoid Array to string conversion warning in SimpleFormatter
TDannhauer Jul 8, 2026
4950f8e
fix(log): only stringify context values that the template references
ralflang Jul 11, 2026
725bdc5
fix(log): type SystemdJournalHandler::$socket as \Socket for PHP 8+
ralflang Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Formatter/SimpleFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ public function format(LogMessage $event): string
$context['levelName'] = $event->level()->name();
$context['message'] = $event->formattedMessage();
foreach ($context as $name => $value) {
if (is_array($value) || is_object($value)) {
$value = json_encode($value);
}
$output = str_replace("%$name%", (string) $value, $output);
}
return $output;
Expand Down
15 changes: 15 additions & 0 deletions test/Formatter/SimpleFormatterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,4 +241,19 @@ public function testFormatConvertsNonStringContextValues(): void
// Should convert boolean to string
$this->assertStringContainsString('Value: 1', $output);
}

public function testFormatWithArrayContextValueDoesNotWarn(): void
{
$formatter = new SimpleFormatter('Extra: %extra%');
$message = new LogMessage(
$this->level,
'test',
['extra' => ['foo' => 'bar']]
);
$message->formatMessage([]);

$output = $formatter->format($message);

$this->assertStringContainsString('Extra: {"foo":"bar"}', $output);
}
}
Loading