Repository navigation
Refresh the redirection bound after alias expansion - #206
Merged
Merged
Conversation
demrom
marked this pull request as ready for review
October 30, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running an alias with its output redirected can abort in
ios_systemwithAssertion failed: (endFile <= maxPointer).maxPointeris set from the original command string. Alias expansion builds the expanded command in a new allocation and frees the original, but the redirection parser still checks file name ends against the old bound. The assert fires only when the new string lands above the end of the old one, so the outcome depends on where malloc puts it.This change recomputes
maxPointerfrom the expanded command before redirections are parsed. The same line covers a command name taken from an environment variable ($NAME), which replaces the string the same way; the test does not exercise that path.tests/alias-redirection.maliases a registered command with two arguments and runs it with stdout and stderr redirected to files. The alias is padded with 2048 spaces: without the padding the test passed even before the fix. With the command intests/README.md(Xcode 27.1, arm64 Release, Simulator SDK 27.1, iOS 15 deployment target) and the added line reverted, the test aborts on the assert in three runs out of three. With this change, all three runs return status 7, and each file holds exactly the expected line.