Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
cd ~/D+ Tab, holding the onscreen Delete key stops before the completed line is empty. Completion updates the host editor, but UIKit still holds only the characters typed before Tab.Reuse
synchronizeRecalledInputContext(_:)from #1137 after Tab completion, right-arrow suggestion acceptance, andupdateAutocompletein the typed-character path. That last path can append a unique match's remaining text, a common prefix, or an option's argument separator. All three calls are ina-Shell/SceneDelegate+TerminalView.swift.Tested in a development build of a-Shell 2.2.2 on a physical iPhone. Tab completed
cd ~/Dtocd ~/Documents/(15 characters). Before the fix, UIKit held 6 characters; two 5-second Delete holds removed 6 characters total and leftcd ~/Docu(9 characters). With the fix, UIKit held all 15 characters and one 5-second hold cleared both the terminal line and UIKit input.Also tested typing
cafter Tab withDocuments/andDownloads/as matches forcd ~/tmp/p/D. Completion producedcd ~/tmp/p/Documents/. Before the fix, UIKit heldcd ~/tmp/p/Dcand an 8-second Delete hold leftcd ~/tmpin the terminal. With the fix, the same hold cleared the line. Repeat-Tab and right-arrow acceptance, mid-line completion,zexpansion, and marked-text input remain untested on the phone.Refs #1137.