Emit peer-bitfield when a peer's bitfield or range message is processed#848
Open
gmaclennan wants to merge 1 commit into
Open
Emit peer-bitfield when a peer's bitfield or range message is processed#848gmaclennan wants to merge 1 commit into
peer-bitfield when a peer's bitfield or range message is processed#848gmaclennan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no way to observe when a peer's remote bitfield is updated by an incoming bitfield or range message. The existing
remote-contiguous-lengthevent covers only the aggregate storage hint, not per-peer state.This PR emits a
peer-bitfieldsession event, mirroringpeer-add/peer-remove, from both handlers after the remote bitfield state has been updated.No behavior change; observability only.
Use case: CoMapeo derives per-peer sync progress (how many blocks each connected device has and still needs) from peers' remote bitfields, and needs a change signal to know when to re-derive.