refactor: inline deepFreeze and drop deep-freeze-es6 - #4473
Open
joshgoebel wants to merge 1 commit into
Open
Conversation
Build Size ReportChanges to minified artifacts in 3 files changedTotal change -198 B View Changes
|
Only used to freeze built-in MODES; a small Object.freeze walk is enough. Avoids tracking a dep whose majors mostly tighten Node engines.
joshgoebel
force-pushed
the
chore/inline-deep-freeze
branch
from
August 9, 2026 07:06
2a6e70e to
2fe4251
Compare
Build Size ReportChanges to minified artifacts in 3 files changedTotal change -207 B View Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Object.freezehelper insrc/lib/utils.js(plain objects only — whatMODESneeds).deep-freeze-es6devDependency.>=22.18and didn’t match our CI matrix.Test plan
node tools/build.js -t nodehljs.C_LINE_COMMENT_MODEis frozen after load