-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(yaml) empty lines should not terminate block scalars #4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pikammmmm
wants to merge
2
commits into
highlightjs:main
Choose a base branch
from
pikammmmm:fix-yaml-block-scalar-empty-lines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <span class="hljs-attr">nested:</span> | ||
| <span class="hljs-attr">literal:</span> <span class="hljs-string">| | ||
| still: a string | ||
|
|
||
| not: anymore | ||
| </span><span class="hljs-attr">folded:</span> <span class="hljs-string">> | ||
| first line | ||
|
|
||
| second line | ||
| </span><span class="hljs-attr">leading-blank:</span> <span class="hljs-string">| | ||
|
|
||
| alpha | ||
| beta | ||
| </span><span class="hljs-attr">blank-has-spaces:</span> <span class="hljs-string">| | ||
| alpha | ||
|
|
||
| beta | ||
| </span><span class="hljs-attr">multiple-blanks:</span> <span class="hljs-string">| | ||
| alpha | ||
|
|
||
|
|
||
| beta | ||
| </span><span class="hljs-attr">trailing-blank:</span> <span class="hljs-string">| | ||
| alpha | ||
| </span> | ||
| <span class="hljs-attr">next_key:</span> <span class="hljs-string">after</span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| nested: | ||
| literal: | | ||
| still: a string | ||
|
|
||
| not: anymore | ||
| folded: > | ||
| first line | ||
|
|
||
| second line | ||
| leading-blank: | | ||
|
|
||
| alpha | ||
| beta | ||
| blank-has-spaces: | | ||
| alpha | ||
|
|
||
| beta | ||
| multiple-blanks: | | ||
| alpha | ||
|
|
||
|
|
||
| beta | ||
| trailing-blank: | | ||
| alpha | ||
|
|
||
| next_key: after |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you added non-capturing? Generally (other than multi-match) our engine doesn't care about capturing or not... is this intended to be a performance improvement or were you just not aware that "capture doesn't matter"?
I wonder if we could break this into multiple lines/regex (with comments) and use our
regex.concactto build the final regex... it's getting a little hard to follow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required here, not perf:
\2has to keep pointing at the indent group( +). If the new groups capture, the indent becomes\3and\2refers to a group that can match zero times, so\2[^\n]+degrades to "any line" and the block swallows what follows it — appendbaz: quuxto the test sample and it gets pulled into the string.Happy to rebuild it as commented pieces via
regex.concat— say the word and I'll push that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, duh. :-)
word.