Skip to content

fix(1c) keep inline query parameters out of metadata - #4451

Open
alencristen wants to merge 3 commits into
highlightjs:mainfrom
alencristen:agent/1c-inline-parameters
Open

fix(1c) keep inline query parameters out of metadata#4451
alencristen wants to merge 3 commits into
highlightjs:mainfrom
alencristen:agent/1c-inline-parameters

Conversation

@alencristen

Copy link
Copy Markdown

Resolves #4226.

Changes

Only match # and & directives at the start of a line, so inline 1C query parameters do not consume the rest of the line. Includes a regression fixture.

Checklist

  • Added markup tests
  • Updated the changelog

@Baltsat Baltsat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested exact head e187cecea08e61db524f9ddee497784ee2597695 against base 29dc139fa8d8bcf14bcae6b4f8323027eca9eed3.

With only the two new fixtures applied to the unpatched base, the focused 1C markup test fails exactly on the inline &НачалоПериода parameter being consumed by META through end of line. On this PR head:

  • npm run build passes
  • ONLY_LANGUAGES=1c npm run test-markup passes (3 passing)
  • npm run lint-languages passes
  • npm run lint passes with the existing ignored vendor warning
  • npm test passes (1582 passing, 3 pending)

The existing fixture for indented &НаКлиенте... directives also remains green, so the start-of-line behavior is preserved while inline query parameters stop being classified as metadata. I found no code-level blocker.

GitHub currently reports a conflict with main; a local merge-tree check shows the conflict is limited to CHANGES.md. Please rebase or resolve that changelog conflict and rerun the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(1C) Ampersand highlight

3 participants