Skip to content

Implementation for complex sorting of dndarrays - #2482

Open
Berkant03 wants to merge 21 commits into
mainfrom
features/2372-complex_sort
Open

Implementation for complex sorting of dndarrays#2482
Berkant03 wants to merge 21 commits into
mainfrom
features/2372-complex_sort

Conversation

@Berkant03

Copy link
Copy Markdown
Collaborator

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • NEW unit tests: MPS tested (1 MPI process, 1 GPU)
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Use vectorized_sort to implement a complex sort similar to np.sort_complex.

Issue/s resolved: #2372

Changes proposed:

  • Create a ht.sort_complex similar to np.sort_complex.
  • Reuse row exchange fuctionality of vectorized_sort.

Type of change

  • New feature (non-breaking change which adds functionality)

Does this change modify the behaviour of other functions? If so, which?

  • vectorized_sort, extraction of the communication logic into a seperate function.

Stack created with GitHub Stacks CLIGive Feedback 💬

@github-project-automation github-project-automation Bot moved this to Todo in Roadmap Aug 24, 2026
@Berkant03 Berkant03 changed the title Implemenation for complex sorting of dndarrays Implementation for complex sorting of dndarrays Aug 24, 2026
@brownbaerchen
brownbaerchen marked this pull request as draft August 25, 2026 10:37
@brownbaerchen

Copy link
Copy Markdown
Collaborator

I marked the PR as draft because I couldn't find any actual implementation or tests for the new feature.

@brownbaerchen
brownbaerchen force-pushed the features/2372-complex_sort branch from daf9b19 to 5bc0d77 Compare August 25, 2026 13:44
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.60317% with 16 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (363-vectorized-sorting@e487637). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
heat/core/manipulations.py 74.60% 16 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             363-vectorized-sorting    #2482   +/-   ##
=========================================================
  Coverage                          ?   83.68%           
=========================================================
  Files                             ?      105           
  Lines                             ?    15760           
  Branches                          ?        0           
=========================================================
  Hits                              ?    13189           
  Misses                            ?     2571           
  Partials                          ?        0           
Flag Coverage Δ
unit 83.68% <74.60%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@brownbaerchen
brownbaerchen force-pushed the features/2372-complex_sort branch from 0f36767 to 7d610a4 Compare August 26, 2026 08:24
Base automatically changed from 363-vectorized-sorting to main August 26, 2026 14:11
@brownbaerchen
brownbaerchen force-pushed the features/2372-complex_sort branch from 7d610a4 to a886580 Compare August 26, 2026 14:11
@Berkant03
Berkant03 marked this pull request as ready for review September 4, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

ht.sort should support complex input

2 participants