Implementation for complex sorting of dndarrays - #2482
Open
Berkant03 wants to merge 21 commits into
Open
Conversation
brownbaerchen
marked this pull request as draft
August 25, 2026 10:37
Collaborator
|
I marked the PR as draft because I couldn't find any actual implementation or tests for the new feature. |
brownbaerchen
force-pushed
the
features/2372-complex_sort
branch
from
August 25, 2026 13:44
daf9b19 to
5bc0d77
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 363-vectorized-sorting #2482 +/- ##
=========================================================
Coverage ? 83.68%
=========================================================
Files ? 105
Lines ? 15760
Branches ? 0
=========================================================
Hits ? 13189
Misses ? 2571
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
brownbaerchen
force-pushed
the
features/2372-complex_sort
branch
from
August 26, 2026 08:24
0f36767 to
7d610a4
Compare
- Started with `sort_complex`
for more information, see https://pre-commit.ci
brownbaerchen
force-pushed
the
features/2372-complex_sort
branch
from
August 26, 2026 14:11
7d610a4 to
a886580
Compare
…es/2372-complex_sort
for more information, see https://pre-commit.ci
- Added final `sort_complex` - integrated `sort_complex` into `sort` - added tests for `sort` for complex arrays
for more information, see https://pre-commit.ci
- add split axis for non distributed case.
Berkant03
marked this pull request as ready for review
September 4, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due Diligence
Description
Use
vectorized_sortto implement a complex sort similar tonp.sort_complex.Issue/s resolved: #2372
Changes proposed:
ht.sort_complexsimilar tonp.sort_complex.vectorized_sort.Type of change
Does this change modify the behaviour of other functions? If so, which?
vectorized_sort, extraction of the communication logic into a seperate function.Stack created with GitHub Stacks CLI • Give Feedback 💬