Skip to content

Fix the any_scan.h value-param findings caused by #272 #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helly25 merged 2 commits into from
Aug 9, 2026
Merged

Fix the any_scan.h value-param findings caused by #272 #278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae05b85
Fix the any_scan.h value-param findings caused by #272
helly25 Aug 8, 2026
a74e20d
Merge branch 'main' into clang_tidy_any_scan
helly25 Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions mbo/container/any_scan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,8 +516,8 @@ class AnyScan : public container_internal::AnyScanImpl<ValueType, DifferenceType
template<::mbo::types::ContainerHasInputIterator Container>
requires(types::ConstructibleFrom<ValueType, typename std::remove_cvref_t<Container>::value_type>)
AnyScan( // NOLINT(*-explicit-constructor,*-explicit-conversions)
container_internal::MakeAnyScanData<Container, container_internal::ScanMode::kAny> data)
: AnyScanImpl(std::move(data)) {}
const container_internal::MakeAnyScanData<Container, container_internal::ScanMode::kAny>& data)
: AnyScanImpl(data) {}

using AnyScanImpl::begin;
using AnyScanImpl::end;
Expand All @@ -539,8 +539,8 @@ class ConstScan
template<container_internal::AcceptableContainer Container>
requires(types::ConstructibleFrom<const ValueType, typename std::remove_cvref_t<Container>::value_type>)
ConstScan( // NOLINT(*-explicit-constructor,*-explicit-conversions)
container_internal::MakeAnyScanData<Container, container_internal::ScanMode::kConst> data)
: AnyScanImpl(std::move(data)) {}
const container_internal::MakeAnyScanData<Container, container_internal::ScanMode::kConst>& data)
: AnyScanImpl(data) {}

using AnyScanImpl::begin;
using AnyScanImpl::end;
Expand All @@ -562,8 +562,8 @@ class ConvertingScan
template<container_internal::AcceptableContainer Container>
requires(types::ConstructibleFrom<ValueType, typename std::remove_cvref_t<Container>::value_type>)
ConvertingScan( // NOLINT(*-explicit-constructor,*-explicit-conversions)
container_internal::MakeAnyScanData<Container, container_internal::ScanMode::kConverting> data)
: AnyScanImpl(std::move(data)) {}
const container_internal::MakeAnyScanData<Container, container_internal::ScanMode::kConverting>& data)
: AnyScanImpl(data) {}

using AnyScanImpl::begin;
using AnyScanImpl::end;
Expand Down
Loading