Skip to content

Clear the three most concentrated clang-tidy checks #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helly25 merged 2 commits into from
Aug 8, 2026
+14 −6
Merged

Clear the three most concentrated clang-tidy checks #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1225c0
Clear the three most concentrated clang-tidy checks
helly25 Aug 8, 2026
313fdd1
Merge branch 'main' into clang_tidy_fix_concentrated
helly25 Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ CheckOptions:
value: 'NULL'
- key: performance-unnecessary-value-param.AllowedTypes
value: 'absl::Status;absl::StatusOr;std::string_view'
- key: readability-implicit-bool-conversion.AllowIntegerConditions
value: '1'
- key: readability-implicit-bool-conversion.AllowPointerConditions
value: '1'
- key: readability-function-cognitive-complexity.Threshold
value: '25'
- key: readability-braces-around-statements.ShortStatementLines
Expand Down
4 changes: 2 additions & 2 deletions mbo/container/any_scan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ class AnyScanImpl {
// For MakAnyScan / MakeConstScan
template<AcceptableContainer Container>
requires(kAccessByRef)
explicit AnyScanImpl(MakeAnyScanData<Container, kScanMode> data)
explicit AnyScanImpl(const MakeAnyScanData<Container, kScanMode>& data)
: funcs_{
.iter =
[data = data] {
Expand All @@ -374,7 +374,7 @@ class AnyScanImpl {
!kAccessByRef // This is the ConvertingScan constructor
&& types::ConstructibleFrom<AccessType, ::mbo::types::ContainerConstIteratorValueType<Container>>
&& types::ConstructibleFrom<value_type, AccessType>)
explicit AnyScanImpl(MakeAnyScanData<Container, kScanMode> data)
explicit AnyScanImpl(const MakeAnyScanData<Container, kScanMode>& data)
: funcs_{
// NOTE: data must be copied here!
.iter =
Expand Down
8 changes: 6 additions & 2 deletions mbo/hash/hash_differential_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@
namespace mbo::hash {
namespace {

// NOLINTBEGIN(*-magic-numbers)
// readability-implicit-bool-conversion is suppressed rather than "fixed": inside
// the reference macros (XXH64 / XXH3_*) it misattributes a conversion to the gtest
// `<<` message chain, pointing at string literals like "len: " and proposing they
// be replaced with `true`. Nothing here converts anything to bool.
// NOLINTBEGIN(*-magic-numbers,readability-implicit-bool-conversion)

TEST(DifferentialTest, Xxh64MatchesReference) {
std::mt19937_64 rng(0xD1FF64U); // NOLINT(cert-msc51-cpp,cert-msc32-c,bugprone-random-generator-seed): reproducible
Expand Down Expand Up @@ -89,7 +93,7 @@ TEST(DifferentialTest, Xxh3Hash128MatchesReference) {
}
}

// NOLINTEND(*-magic-numbers)
// NOLINTEND(*-magic-numbers,readability-implicit-bool-conversion)

} // namespace
} // namespace mbo::hash
4 changes: 2 additions & 2 deletions mbo/strings/numbers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ unsigned BigNumberLen(T v) {
// We first check whether we can do even better by limiting us to 4 byte types.
// We use a macro to let the compiler compute the actual length values.
if constexpr (sizeof(v) <= 4) {
#define CHECK_CAP(cap) std::make_pair<uint32_t, unsigned>(cap, std::string_view(#cap).size() - 3)
#define CHECK_CAP(cap) std::pair<uint32_t, unsigned>(cap, std::string_view(#cap).size() - 3)
constexpr auto kData = mbo::container::ToLimitedMap<std::pair<uint32_t, unsigned>>({
CHECK_CAP(4'294'967'295ULL),
CHECK_CAP(999'999'999ULL),
Expand All @@ -68,7 +68,7 @@ unsigned BigNumberLen(T v) {
#undef CHECK_CAP
return kData.lower_bound(v)->second;
} else {
#define CHECK_CAP(cap) std::make_pair<uint64_t, unsigned>(cap, std::string_view(#cap).size() - 3)
#define CHECK_CAP(cap) std::pair<uint64_t, unsigned>(cap, std::string_view(#cap).size() - 3)
constexpr auto kData = mbo::container::ToLimitedMap<std::pair<uint64_t, unsigned>>({
CHECK_CAP(18'446'744'073'709'551'615ULL),
CHECK_CAP(9'999'999'999'999'999'999ULL),
Expand Down
Loading