Repository navigation
Conversation
One Galahad2LightingDeviceProvider/FrameWriter drives both the wired Trinity and the LCD variant - the reference driver's has_pump_rgb covers Galahad2Lcd and Galahad2Vision with the same set_pump_light (0x83, inner/outer/both), and only which object holds the HID handle differs. IGalahad2PumpTransport (IsConnected + SendLighting) abstracts that; Galahad2Hub and the LCD's JpegPanelHub each implement it, and the provider uses whichever is actually connected. This removes the nullable second provider from the composite along with its `?? ` fallbacks. No per-LED (0x14) path: three public drivers (lian-li-linux, OpenRGB, FanControl.LianLi) all describe this pump as 0x83-only, and the per-LED byte layout had no citable source, so it's dropped rather than shipped uncited. The LCD pump now gets the same inner/outer canvas colours as the Trinity through the shared 0x83 path. LightingDevicesCatalog marks the row rgb-capable (previously screen-only). Tested on real Galahad II LCD hardware: canvas colours apply to the pump head through the two-ring path.
|
Both points addressed: One provider — folded the LCD into the existing 0x14 — took option 1: dropped it, shipped the LCD pump on the reference-backed Comments trimmed to one line each, no provenance narrative. Also closed #1 and opened this fresh off |
|
Reopened as #5 with the structure fixed (the LCD's pump is one 12-LED ring, not the Trinity's two 1-LED rings this version assumed) and the 0x14 per-LED command restored with a real citation. GitHub wouldn't let me reopen this PR directly. |
Resubmit of the pump RGB half of the earlier PR (#1, closed), addressing the review there.
Summary
Galahad2LightingDeviceProvider/Galahad2LightingFrameWriternow drives both the wired Trinity and the LCD variant, through a smallIGalahad2PumpTransport(IsConnected+SendLighting) thatGalahad2Huband the LCD'sJpegPanelHubeach implement - only which object holds the HID handle differs. No second provider, no nullable fallbacks in the composite.0x83inner/outer/both command the wired Trinity already uses - confirmed againstlian-li-linux, OpenRGB, and FanControl.LianLi, all of which describe this pump as0x83-only.0x14) path entirely: it had no citable source, so it's not shipped uncited. Can come back as a follow-up once there's something to cite (lian-li-linuxdoesn't have it; checked).LightingDevicesCatalogmarks the Galahad II LCD row rgb-capable (previously screen-only).Test plan
dotnet buildsucceedsI've read and agree to the CLA (CONTRIBUTING.md / CLA.md).