This repository was archived by the owner on Oct 29, 2021. It is now read-only.
Make "Set-Cookie" header in the response optional#187
Open
AliasQli wants to merge 1 commit into
Open
Conversation
Collaborator
|
@AliasQli what's the use case? |
Author
|
@domenkozar Because it's often the desired behaviour of an API server. At least in my use case, there's only one central place for verification (for example, login) and the server will respond with a JSON containing the JWT token, like this: {
"token": "someJwtToken"
}And the client will use this token in all its following requests as its bearer token. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that often it's not needed to pass a JWT token in cookie.
A field is added to
CookieSettingsto let the used specify whether to generateSet-Cookieheaders. The default value for it isTrue, so the default behavior is kept the same as prevoius versions.I made as little change as possible to add this feature.