Fix issue with odd number of arguments for Hash - #13758
Open
hedrok wants to merge 1 commit into
Open
Conversation
In case `sshd -T | grep key` returns some lines without spaces Hash creation in communicator.rb failed with ArgumentError "odd number of arguments for Hash". As only "pubkeyacceptedalgorithms", "pubkeyacceptedkeytypes", "hostkeyalgorithms" are needed, change to ignore lines that have no space.
|
As mentioned this also happens if the output contains terminal escape sequences, eq. "\e]0;\a" is a sequence to set the terminal title |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case
sshd -T | grep keyreturns some lines without spaces Hash creation in communicator.rb failed with ArgumentError "odd number of arguments for Hash".As only "pubkeyacceptedalgorithms", "pubkeyacceptedkeytypes", "hostkeyalgorithms" are needed, change to ignore lines that have no space.
This fixes error:
I got it while trying to launch NixOS under Vagrant with https://github.com/nix-community/nixbox.git.
listin line 872 of communicator.rb ends withI don't know yet where
\e]0;\acame from, but anyway I think ignoring lines without spaces here is good idea.