consensus: add total vote/commit metrics to measure on-time vs late - #5099
Open
GheisMohammadi wants to merge 1 commit into
Open
consensus: add total vote/commit metrics to measure on-time vs late#5099GheisMohammadi wants to merge 1 commit into
GheisMohammadi wants to merge 1 commit into
Conversation
Frozen
reviewed
Aug 12, 2026
| consensus.getLogger().Warn().Err(err).Msg("[OnPrepare] prepareBitmap.SetKey failed") | ||
| return | ||
| } | ||
| consensus.reportAcceptedVote(recvMsg.MessageType.String()) |
Collaborator
There was a problem hiding this comment.
Just to clarify the intended behavior: if a validator sends one aggregated vote containing 10 BLS keys, signature_total is incremented by 1 rather than 10 here. Is that the expected unit for this metric?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
hmy_consensus_signature_totalso we can see how many prepare/commit votes and local commit inclusions were on time vs late. The existinghmy_consensus_late_signaturemetric is unchanged.Metrics
Both counters use the same labels:
role(leader|validator) andphase(PREPARE|COMMIT|committed).hmy_consensus_signature_totalhmy_consensus_late_signatureLeader (
role=leader,phase=PREPAREorCOMMIT)Validator (
role=validator,phase=committed)How to calculate
hmy_consensus_signature_totalhmy_consensus_late_signaturesignature_total - late_signaturelate_signature / signature_total1 - (late_signature / signature_total)Example PromQL: