Skip to content

fix(consensus): count hooray only after successful final commit #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frozen merged 1 commit into from
Aug 6, 2026
+0 −2
Merged

fix(consensus): count hooray only after successful final commit #5097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions consensus/leader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ func (consensus *Consensus) onPrepare(recvMsg *FBFTMessage) {
}
//// Read - End

consensus.UpdateLeaderMetrics(float64(signerCount), float64(consensus.getBlockNum()))

// Check BLS signature for the multi-sig
prepareSig := recvMsg.Payload
var sign bls_core.Sign
Expand Down