Skip to content

Reduced block production timeout - #5016

Merged
GheisMohammadi merged 1 commit into
devfrom
feature-reduced-min-time-1-sec-finality
Aug 7, 2026
Merged

Reduced block production timeout#5016
GheisMohammadi merged 1 commit into
devfrom
feature-reduced-min-time-1-sec-finality

Conversation

@Frozen

@Frozen Frozen commented Mar 8, 2026

Copy link
Copy Markdown
Collaborator

Reduced block production timeout. On my local machine produced 1639 block for 1664 seconds which is no more than 1.5% deviation for the ideal scenario

@Frozen Frozen self-assigned this Mar 8, 2026
@mur-me

mur-me commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator

Let's check this on the devnet as we discussed

@mur-me

mur-me commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

Well, what we have right now after the run in the devnet:

  • it was good in the logs - all 60 blocks were produced and validated, but only in the logs.
  • but in fact, external validators, especially far away geographically from the current leader was signing only 12-15% of the blocks and were kicked off from the committee.
  • only shard 0 was affected, when the shard 1 nodes were good generally.

Right now I'm suspecting that there should be more investigation or/and code change for the shard 0

@Frozen
Frozen force-pushed the feature-reduced-min-time-1-sec-finality branch 2 times, most recently from 1b9db77 to cd8dc9d Compare May 26, 2026 20:56
@mur-me

mur-me commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Deployed on devnet, hardfork in 9 epochs

@mur-me

mur-me commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Tested, result is the same, we still have issue on the shard 0 like previous time.

Some of geographically far away nodes are still signing less blocks than 66.6% and getting kicked from the committee:

Address Epoch Signed To-sign Percent Status
one1tedqsp6fm47cmp7xk5m44stvz8pxjmzursl2r5 50370 1132 1774 63.81% active
one1d95s9qrvrryfawysa9jvpxysxwazyt45zd6su3 50370 736 896 82.14% active
one13djpgmsunxm3dzdjq6855hx905r8a86fa0wzhv 50370 2101 2688 78.16% active
one1mgjpfcz8w7nkakwty7errmcf956yp239umnfv6 50370 738 1774 41.60% active
one1ymyg4d0y4w8g6ythply0lkmp5dr6dvdxj5e67w 50370 507 887 57.16% active

@GheisMohammadi

GheisMohammadi commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

This idea doesn't work.

With waitTime = 0, the leader freezes the bitmap as soon as 2/3 is reached. Validators whose commit messages are still in flight are recorded as missing, even if they signed prepare and sent commit on time. So they will be excluded from the next epoch committee:

@Frozen
Frozen force-pushed the feature-reduced-min-time-1-sec-finality branch from 652294b to ecd810a Compare August 3, 2026 18:29
@Frozen

Frozen commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot rebase on dev

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@copilot rebase on dev

Done, rebased on dev (commit 740530f).

@mur-me

mur-me commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@Frozen copilot have done strange rebase, it is including 2 commits already in the dev into you PR

@mur-me

mur-me commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Other than that, I've tested this change on the devnet, both validation + block producing are around 60 blocks per minute for 24 hours, before it was around 35-42:
image

Let's do a final decision on the tomorrow meeting

@Frozen
Frozen force-pushed the feature-reduced-min-time-1-sec-finality branch from 531c565 to 4f688b5 Compare August 5, 2026 16:31
@Frozen

Frozen commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator Author

@mur-me rebased

@mergify

mergify Bot commented Aug 7, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@GheisMohammadi
GheisMohammadi merged commit cf69850 into dev Aug 7, 2026
11 checks passed
@mur-me
mur-me deleted the feature-reduced-min-time-1-sec-finality branch August 7, 2026 06:51
@mur-me

mur-me commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

#5097 - fixed hooray counting on the hmy_consensus_bingo metric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants