Skip to content

[misc]: surface GenerationResult.peak_memory_mb in the MiniMax H3 examples #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyleNeverGivesUp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[misc]: surface GenerationResult.peak_memory_mb in the MiniMax H3 examples #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/inference/basic/basic_fasth3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,9 @@ def run(args: argparse.Namespace) -> list[float]:
generation_time = getattr(result, "generation_time", None)
if generation_time is not None:
print(f"Generation time: {float(generation_time):.3f}s")
peak_memory_mb = getattr(result, "peak_memory_mb", None)
if peak_memory_mb is not None:
print(f"Peak memory: {float(peak_memory_mb):.1f} MB")
denoise_time = _denoise_seconds(result)
if denoise_time is not None:
measured_denoise_times.append(denoise_time)
Expand Down
4 changes: 4 additions & 0 deletions examples/inference/basic/basic_minimax_h3_t2v.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,14 @@ def main() -> None:
# machine-readable: benchmark harnesses parse this line to separate
# generation from model-load time (last occurrence = steady state)
print(f"Generation time: {result.generation_time:.2f}s")
if result.peak_memory_mb is not None:
print(f"Peak memory: {result.peak_memory_mb:.1f} MB")
for _ in range(args.repeats - 1):
result = generator.generate(request)
if result.generation_time is not None:
print(f"Generation time: {result.generation_time:.2f}s")
if result.peak_memory_mb is not None:
print(f"Peak memory: {result.peak_memory_mb:.1f} MB")
finally:
generator.shutdown()

Expand Down
Loading