Skip to content

プラグインヘッダーからDomain Pathを削除 - #68

Merged
fumikito merged 1 commit into
masterfrom
fix/remove-domain-path-header
Jul 3, 2026
Merged

fumikito merged 1 commit into
masterfrom
fix/remove-domain-path-header

Conversation

@fumikito

@fumikito fumikito commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary

  • languages/をgit管理から除外した結果、hamethread.phpのDomain Path: /languagesヘッダーが存在しないディレクトリを指すことになり、Plugin Checkで警告が出ていた(PR #31のCIログで検出)
  • org掲載プラグインはGlotPressが翻訳を配信するため、このヘッダー自体が不要

Test plan

  • php -l hamethread.php
  • composer lint

languages/をgit管理から除外したため、存在しないディレクトリを指す状態になっていた(Plugin Check指摘)。org掲載プラグインはGlotPressが翻訳を配信するため不要。

Co-authored-by: Claude <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'Domain Path: /languages' header from the hamethread.php file. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
35 0 35

⚠️ Warnings (35)

📁 functions.php (10 warnings)
📍 Line 🔖 Check 💬 Message
172 WordPress.DB.DirectDatabaseQuery.DirectQuery Use of a direct database call is discouraged.
172 WordPress.DB.DirectDatabaseQuery.NoCaching Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().
189 WordPress.DB.DirectDatabaseQuery.DirectQuery Use of a direct database call is discouraged.
189 WordPress.DB.DirectDatabaseQuery.NoCaching Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().
206 WordPress.DB.DirectDatabaseQuery.DirectQuery Use of a direct database call is discouraged.
206 WordPress.DB.DirectDatabaseQuery.NoCaching Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().
548 WordPress.DB.DirectDatabaseQuery.DirectQuery Use of a direct database call is discouraged.
548 WordPress.DB.DirectDatabaseQuery.NoCaching Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().
564 WordPress.DB.DirectDatabaseQuery.DirectQuery Use of a direct database call is discouraged.
564 WordPress.DB.DirectDatabaseQuery.NoCaching Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().
📁 app/Hametuha/Thread/Rest/RestVote.php (2 warnings)
📍 Line 🔖 Check 💬 Message
159 WordPress.DB.DirectDatabaseQuery.DirectQuery Use of a direct database call is discouraged.
159 WordPress.DB.DirectDatabaseQuery.NoCaching Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().
📁 includes/best-answer.php (1 warning)
📍 Line 🔖 Check 💬 Message
27 WordPress.DB.SlowDBQuery.slow_db_query_meta_query Detected usage of meta_query, possible slow query.
📁 app/Hametuha/Thread/Hooks/AutoClose.php (1 warning)
📍 Line 🔖 Check 💬 Message
68 WordPress.DB.SlowDBQuery.slow_db_query_meta_query Detected usage of meta_query, possible slow query.
📁 app/Hametuha/Thread/Rest/RestThreads.php (2 warnings)
📍 Line 🔖 Check 💬 Message
102 WordPress.DB.SlowDBQuery.slow_db_query_meta_query Detected usage of meta_query, possible slow query.
112 WordPress.DB.SlowDBQuery.slow_db_query_meta_query Detected usage of meta_query, possible slow query.
📁 template-parts/form-thread.php (1 warning)
📍 Line 🔖 Check 💬 Message
45 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$topic".
📁 template-parts/button-thread-controller.php (12 warnings)
📍 Line 🔖 Check 💬 Message
7 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$key".
8 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$label".
10 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$key".
11 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$label".
13 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$lock_action".
14 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$lists".
23 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$resolved".
24 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$resolve_label".
31 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$lists".
48 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$lists".
52 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$lists".
67 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$list".
📁 template-parts/button-thread.php (1 warning)
📍 Line 🔖 Check 💬 Message
10 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$attr".
📁 template-parts/comment-watcher.php (2 warnings)
📍 Line 🔖 Check 💬 Message
25 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$followers".
35 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$user".
📁 template-parts/woocommerce-my-account.php (1 warning)
📍 Line 🔖 Check 💬 Message
9 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$thread_count".
📁 app/Hametuha/Thread/Model/CommentModel.php (1 warning)
📍 Line 🔖 Check 💬 Message
36 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "comment_text".
📁 app/Hametuha/Thread/Model/ThreadModel.php (1 warning)
📍 Line 🔖 Check 💬 Message
43 WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "the_content".

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

@fumikito
fumikito merged commit 19448c6 into master Jul 3, 2026
11 checks passed
@fumikito
fumikito deleted the fix/remove-domain-path-header branch July 3, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant