Skip to content

feat(share): Enhance URL sharing to robustly handle extra URL parameters #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TKanX wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −8
Open

feat(share): Enhance URL sharing to robustly handle extra URL parameters #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
205fc11
feat: Improve URL data handling by checking for 'data' parameter
TKanX Apr 9, 2025
3a2a6ca
feat: Update sharing URL to include 'data' parameter for compressed l…
TKanX Apr 9, 2025
a4aeaa5
fix: Avoid using default URL decoding which can break Base64 encoding
TKanX Apr 9, 2025
afafea7
feat: Update save URL to include 'data' parameter for serialized leve…
TKanX Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Types/Entities/Level/Editor/LevelEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,8 @@ Share -> open dialog w/ serialized JSON with edit: false, name: "Custom"

function onShareButtonClicked() {
const serialized = serialize('CUSTOM_LEVEL')
const url =
location.origin +
'?' +
LZString.compressToBase64(JSON.stringify(serialized))
const compressed = LZString.compressToBase64(JSON.stringify(serialized))
const url = `${location.origin}?data=${compressed}`
ui.puzzleLink.value = url
showDialog(ui.editorSharingLinkDialog)
}
Expand Down
2 changes: 1 addition & 1 deletion Types/Entities/Level/Level.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ function Level(spec) {
history.pushState(
null,
null,
'?' + LZString.compressToBase64(JSON.stringify(serialized)),
'?data=' + LZString.compressToBase64(JSON.stringify(serialized)),
)
// console.log('Writing to URL:', serialized)
}
Expand Down
7 changes: 4 additions & 3 deletions Types/Entities/World.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,14 +439,15 @@ function World(spec) {
function getUrlData() {
const url = new URL(location)

if (url.search) {
if (url.searchParams.has('data')) {
try {
const compressedData = location.href.split('data=')[1]?.split('&')[0]
const urlData = JSON.parse(
LZString.decompressFromBase64(url.search.slice(1)),
LZString.decompressFromBase64(compressedData),
)
return urlData
} catch (err) {
console.error('Error loading url:', err)
console.error('Error loading URL data:', err)
// TODO: Maybe switch to modal
alert('Sorry, this URL is malformed :(')
}
Expand Down