Memory Observer improvements: - #1927
Open
notdodgeball wants to merge 5 commits into
Open
CodeScene Delta Analysis / CodeScene Code Health Review (main)
failed
Jun 14, 2026 in 43s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Deep, Nested Complexity)
(1 file with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| memory_observer.cc | 1 critical rule | 5.07 → 4.72 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| memory_observer.cc | 1 advisory rule | 5.07 → 4.72 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method memory_observer.cc: PCSX::Widgets::MemoryObserver::draw
- Deep, Nested Complexity memory_observer.cc: PCSX::Widgets::MemoryObserver::draw
Annotations
Check warning on line 460 in src/gui/widgets/memory_observer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
PCSX::Widgets::MemoryObserver::draw increases in cyclomatic complexity from 99 to 116, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 460 in src/gui/widgets/memory_observer.cc
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Deep, Nested Complexity
PCSX::Widgets::MemoryObserver::draw increases in nested complexity depth from 7 to 8, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Loading