Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions bau/bau.js
Original file line number Diff line number Diff line change
Expand Up @@ -301,14 +301,9 @@ export default function Bau(input) {
state.val = runAndCaptureDeps(computed, deps);

let listener = { computed, state };
for (let dep of new Set(
[...deps.g].filter(
(dep) =>
!deps.s.has(dep) &&
dep.listeners.every((listener) => !deps.g.has(listener.state))
)
))
dep.listeners.push(listener);
for (let dep of new Set([...deps.g].filter((dep) => !deps.s.has(dep)))) {
if (!dep.listeners.some((l) => l.state === state)) dep.listeners.push(listener);
}
state.dirty = false;
};

Expand Down
21 changes: 21 additions & 0 deletions bau/test/derive.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,25 @@ describe("derive", async () => {
assert.equal(derived.val, 1);
assert.equal(called, 2);
});

it("does not recompute more than once per update", async () => {
const a = bau.state(0);
let called = 0;
const d = bau.derive(() => {
called++;
return a.val + 1;
});
// Initial compute
assert.strictEqual(d.val, 1);
assert.strictEqual(called, 1);
// Drive several recomputations to simulate potential duplicate subscriptions
a.val = 2; await sleep();
a.val = 3; await sleep();
a.val = 4; await sleep();
const before = called;
// A single update should trigger exactly one recompute
a.val = 5; await sleep();
assert.strictEqual(called - before, 1);
Comment thread
louwers marked this conversation as resolved.
assert.strictEqual(d.val, 6);
});
});